Re: [PR] MINOR: Document JBOD limitation during migration [kafka]

2024-04-12 Thread via GitHub


showuon merged PR #15692:
URL: https://github.com/apache/kafka/pull/15692


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Document JBOD limitation during migration [kafka]

2024-04-11 Thread via GitHub


chia7712 commented on code in PR #15692:
URL: https://github.com/apache/kafka/pull/15692#discussion_r1561262953


##
docs/ops.html:
##
@@ -3823,6 +3823,7 @@ Limitations
   version (also known as the inter.broker.protocol.version.) 
Please do not attempt to do this during
   a migration, or you may break the cluster.
 After the migration has been finalized, it is not possible to revert 
back to ZooKeeper mode.
+During the migration, if a ZK broker is running with multiple log 
directories, any directory failure will cause the broker to shutdown. Brokers 
with broken log directories will only be able to migrate to KRaft once the 
directories are repaired. For further details refer to https://issues.apache.org/jira/browse/KAFKA-16431;>KAFKA-16431.

Review Comment:
   Could we split it into multiple lines?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Document JBOD limitation during migration [kafka]

2024-04-11 Thread via GitHub


soarez commented on code in PR #15692:
URL: https://github.com/apache/kafka/pull/15692#discussion_r1561246886


##
docs/ops.html:
##
@@ -3823,6 +3823,7 @@ Limitations
   version (also known as the inter.broker.protocol.version.) 
Please do not attempt to do this during
   a migration, or you may break the cluster.
 After the migration has been finalized, it is not possible to revert 
back to ZooKeeper mode.
+During the migration, if a ZK broker is running with multiple log 
directories, any directory failure will cause the broker to shutdown.

Review Comment:
   @chia7712 great points. Updated. PTAL
   
   @showuon No, the current plan/intention is to have that as simplification 
during the migration. See https://issues.apache.org/jira/browse/KAFKA-16431. 
Please let me know if you have any concerns with this approach. cc @cmccabe 
@pprovenzano 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Document JBOD limitation during migration [kafka]

2024-04-11 Thread via GitHub


showuon commented on code in PR #15692:
URL: https://github.com/apache/kafka/pull/15692#discussion_r1560679096


##
docs/ops.html:
##
@@ -3823,6 +3823,7 @@ Limitations
   version (also known as the inter.broker.protocol.version.) 
Please do not attempt to do this during
   a migration, or you may break the cluster.
 After the migration has been finalized, it is not possible to revert 
back to ZooKeeper mode.
+During the migration, if a ZK broker is running with multiple log 
directories, any directory failure will cause the broker to shutdown.

Review Comment:
   Also, I think that's the current status (v3.7.0), right? Will we fix that in 
the future release?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Document JBOD limitation during migration [kafka]

2024-04-11 Thread via GitHub


chia7712 commented on code in PR #15692:
URL: https://github.com/apache/kafka/pull/15692#discussion_r1560582454


##
docs/ops.html:
##
@@ -3823,6 +3823,7 @@ Limitations
   version (also known as the inter.broker.protocol.version.) 
Please do not attempt to do this during
   a migration, or you may break the cluster.
 After the migration has been finalized, it is not possible to revert 
back to ZooKeeper mode.
+During the migration, if a ZK broker is running with multiple log 
directories, any directory failure will cause the broker to shutdown.

Review Comment:
   If I'm a user, I'd like to know - 
   1) the jira link about "why" 
   2) the workaround about "how"
   WDTY?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org