Re: jmx-dev RFR 8067241 DeadlockTest.java failed with negative timeout value

2014-12-15 Thread shanliang
Jaroslav Bachorik wrote: Hi, On 12/12/2014 09:56 AM, shanliang wrote: Daniel Fuchs wrote: Hi Shanliang, These two statements are no longer needed and should be removed - as they are misleading: 64 if (!bb.gotLock) { 65 throw new RuntimeException("Failed to get loc

Re: jmx-dev RFR 8067241 DeadlockTest.java failed with negative timeout value

2014-12-15 Thread Daniel Fuchs
On 12/12/14 09:56, shanliang wrote: Updated. Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8067241/01/ Thanks, Shanliang Hi Shanliang, Your changes looks good to me. WRT using a Phaser, it would require a careful analysis to assert that modifying the locking strategy - espe