Thank you Alex and Chris for reviewing this change!
Best regards,
Daniil
On 1/24/20, 10:38 AM, "Alex Menkov" wrote:
+1
--alex
On 01/22/2020 19:02, Chris Plummer wrote:
> Looks good.
>
> Chris
>
> On 1/22/20 3:30 PM, Daniil Titov wrote:
>> Hi Chri
+1
--alex
On 01/22/2020 19:02, Chris Plummer wrote:
Looks good.
Chris
On 1/22/20 3:30 PM, Daniil Titov wrote:
Hi Chris,
Please review a new version of the fix [1] that converts the check to
the assert.
Also, I'm not clear on the need for the *pkernelLoad
initialization. It
seem
Looks good.
Chris
On 1/22/20 3:30 PM, Daniil Titov wrote:
Hi Chris,
Please review a new version of the fix [1] that converts the check to the
assert.
Also, I'm not clear on the need for the *pkernelLoad initialization. It
seems this is attempting to fix a different issue, but it's a
Hi Chris,
Please review a new version of the fix [1] that converts the check to the
assert.
>Also, I'm not clear on the need for the *pkernelLoad initialization. It
>seems this is attempting to fix a different issue, but it's already
>initialized to 0 at the start of the function.
Hi Daniil,
Do you think it's worth changing the check to an assert instead of
removing it?
Also, I'm not clear on the need for the *pkernelLoad initialization. It
seems this is attempting to fix a different issue, but it's already
initialized to 0 at the start of the function.
thanks,
Chr
Please review a change that removes unnecessary workaround in
UnixOperatingSystem.c.
It looks as this workaround
if (pticks->usedKernel < tmp.usedKernel) {
kdiff = 0;
}
was added to compensate a missed initialization of counters.jvmTicks that
resulted in the new
counters being comp
