Re: jmx-dev RFR: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo [v5]

2021-01-22 Thread Severin Gehwolf
On Thu, 21 Jan 2021 20:46:12 GMT, Chris Plummer wrote: > Getting close: > > * Line 188 where there is a JNU_ThrowOutOfMemoryError needs a > PopLocalFrame before it. > * Copyrights need updating Should be fixed now. Thoughts? - PR: https://git.openjdk.java.net/jdk/pull/213

Re: jmx-dev RFR: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo [v6]

2021-01-22 Thread Severin Gehwolf
> This patch adds some explicit capacity for local refs. New regression test > fails prior and passes after the patch. > > Thoughts? Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in b

Re: jmx-dev RFR: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo [v5]

2021-01-22 Thread Severin Gehwolf
On Thu, 21 Jan 2021 20:46:12 GMT, Chris Plummer wrote: >> Severin Gehwolf has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Improve popping of local frames in the error case >> - Make HOTSPOT_DIAGNOSTIC_MXBEAN_NAME final > > Getting clo

Re: jmx-dev RFR: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo [v6]

2021-01-22 Thread Chris Plummer
On Fri, 22 Jan 2021 09:37:45 GMT, Severin Gehwolf wrote: >> This patch adds some explicit capacity for local refs. New regression test >> fails prior and passes after the patch. >> >> Thoughts? > > Severin Gehwolf has updated the pull request with a new target base due to a > merge or a rebase.