Re: jmx-dev RFR: 8265836: OperatingSystemImpl.getCpuLoad() returns incorrect CPU load inside a container [v2]

2021-05-11 Thread Hao Tang
> OperatingSystemImpl.getCpuLoad() may return 1.0 in a container, even though > the CPU load is obviously below 100%. > > We created a 5-core container and run 4 "while (true)" loops in the > container. OperatingSystemImpl.getCpuLoad() returned 1.0, which is incorrect > (0.8 is correct). > "sys

Re: jmx-dev RFR: 8265836: OperatingSystemImpl.getCpuLoad() returns incorrect CPU load inside a container [v2]

2021-05-11 Thread Hao Tang
On Thu, 6 May 2021 02:34:01 GMT, Hao Tang wrote: >> Thanks for linking that. It sounds reasonable to me to prefer `quota` in >> that case. > >> Thanks for linking that. It sounds reasonable to me to prefer `quota` in >> that case. > > Yes, flag `PreferContainerQuotaForCPUCount` is [true by >

Re: jmx-dev RFR: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap [v2]

2021-05-11 Thread Pavel Rappo
On Wed, 5 May 2021 19:22:11 GMT, Daniel Fuchs wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed more typos > > src/jdk.management.agent/share/classes/sun/management/jmxremote/ConnectorBootstrap.java > line 308:

Re: jmx-dev RFR: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap [v3]

2021-05-11 Thread Pavel Rappo
> This fixes two javadoc tag references and several typos. References are fixed > by removing whitespace before the opening `(`. That whitespace caused the > opening `(` and the rest of the reference to be parsed as a link label. > > Since we are here, I think this class could also benefit from

Re: jmx-dev RFR: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap [v3]

2021-05-11 Thread Serguei Spitsyn
On Tue, 11 May 2021 22:57:24 GMT, Pavel Rappo wrote: >> This fixes two javadoc tag references and several typos. References are >> fixed by removing whitespace before the opening `(`. That whitespace caused >> the opening `(` and the rest of the reference to be parsed as a link label. >> >> Si