[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-02-27 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
c46395bea47800a5e819cde6ce6db67e97b8e911 / hwang-cadent 
Fix dynamic dag_id resolution in TriggerDagRunOperator links

- Add XCOM_DAG_ID constant to store resolved dag_id in XCom
- Update TriggerDagRunLink.get_link() to check XCom first for dynamic dag_ids
- Store resolved dag_id in XCom during execution for both Airflow 2.x and 3.x
- Add comprehensive tests for dynamic dag_id link generation
- Maintain backward compatibility with existing static dag_id usage
- Fix deserialization of logical_date when it's NOTSET

Fixes #46402

diff --git a/airflow-core/src/airflow/serialization/serialized_objects.py 
b/airflow-core/src/airflow/serialization/serialized_objects.py
index db79e79944..a9f1c3c770 100644

--- a/airflow-core/src/airflow/serialization/serialized_objects.py
+++ b/airflow-core/src/airflow/serialization/serialized_objects.py
@@ -1595,6 +1595,11 @@ class OperatorSerialization(DAGNode, BaseSerialization):
 elif field_name == "resources":
 return Resources.from_dict(value) if value is not None else None
 elif field_name.endswith("_date"):
+# Check if value is ARG_NOT_SET before trying to deserialize as 
datetime
+if isinstance(value, dict) and value.get(Encoding.TYPE) == 
DAT.ARG_NOT_SET:
+from airflow.serialization.definitions.notset import NOTSET
+
+return NOTSET
 return cls._deserialize_datetime(value) if value is not None else 
None
 else:
 # For all other fields, return as-is (strings, ints, bools, etc.)
diff --git 
a/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py 
b/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
index ae3f978da4..728a1cf5ba 100644
--- 
a/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
+++ 
b/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
@@ -53,6 +53,7 @@ except ImportError:

 XCOM_LOGICAL_DATE_ISO = "trigger_logical_date_iso"
 XCOM_RUN_ID = "trigger_run_id"
+XCOM_DAG_ID = "trigger_dag_id"

 if TYPE_CHECKING:
@@ -85,21 +86,26 @@ class TriggerDagRunLink(BaseOperatorLink):
 if TYPE_CHECKING:
 assert isinstance(operator, TriggerDagRunOperator)

-trigger_dag_id = operator.trigger_dag_id
-if not AIRFLOW_V_3_0_PLUS:
-from airflow.models.renderedtifields import 
RenderedTaskInstanceFields
-from airflow.models.taskinstancekey import TaskInstanceKey as 
CoreTaskInstanceKey
-
-core_ti_key = CoreTaskInstanceKey(
-dag_id=ti_key.dag_id,
-task_id=ti_key.task_id,
-run_id=ti_key.run_id,
-try_number=ti_key.try_number,
-map_index=ti_key.map_index,
-)
+# Try to get the resolved dag_id from XCom first (for dynamic dag_ids)
+trigger_dag_id = XCom.get_value(ti_key=ti_key, key=XCOM_DAG_ID)
+
+# Fallback to operator attribute and rendered fields if not in XCom
+if not trigger_dag_id:
+trigger_dag_id = operator.trigger_dag_id
+if not AIRFLOW_V_3_0_PLUS:
+from airflow.models.renderedtifields import 
RenderedTaskInstanceFields
+from airflow.models.taskinstancekey import TaskInstanceKey as 
CoreTaskInstanceKey
+
+core_ti_key = CoreTaskInstanceKey(
+dag_id=ti_key.dag_id,
+task_id=ti_key.task_id,
+run_id=ti_key.run_id,
+try_number=ti_key.try_number,
+map_index=ti_key.map_index,
+)

-if template_fields := 
RenderedTaskInstanceFields.get_templated_fields(core_ti_key):
-trigger_dag_id: str = template_fields.get("trigger_dag_id", 
operator.trigger_dag_id)  # type: ignore[no-redef]
+if template_fields := 
RenderedTaskInstanceFields.get_templated_fields(core_ti_key):
+trigger_dag_id: str = 
template_fields.get("trigger_dag_id", operator.trigger_dag_id)  # type: 
ignore[no-redef]

 # Fetch the correct dag_run_id for the triggerED dag which is
 # stored in xcom during execution of the triggerING task.
@@ -203,7 +209,7 @@ class TriggerDagRunOperator(BaseOperator):
 self.openlineage_inject_parent_info = openlineage_inject_parent_info
 self.deferrable = deferrable
 self.logical_date = logical_date
-if logical_date is NOTSET:
+if isinstance(logical_date, ArgNotSet) or logical_date is NOTSET:
 self.logical_date = NOTSET
 elif logical_date is None or isinstance(logical_date, (str, 
datetime.datetime)):
 self.logical_date = logical_date
@@ -216,7 +222,7 @@ class TriggerD

[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-02-24 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
13cc6cd9c52a5a7bc0b35461f644e8ddeb061522 / hwang-cadent 
Fix dynamic dag_id resolution in TriggerDagRunOperator links

- Add XCOM_DAG_ID constant to store resolved dag_id in XCom
- Update TriggerDagRunLink.get_link() to check XCom first for dynamic dag_ids
- Store resolved dag_id in XCom during execution for both Airflow 2.x and 3.x
- Add comprehensive tests for dynamic dag_id link generation
- Maintain backward compatibility with existing static dag_id usage
- Fix deserialization of logical_date when it's NOTSET

Fixes #46402

diff --git a/airflow-core/src/airflow/serialization/serialized_objects.py 
b/airflow-core/src/airflow/serialization/serialized_objects.py
index db79e79944..a9f1c3c770 100644

--- a/airflow-core/src/airflow/serialization/serialized_objects.py
+++ b/airflow-core/src/airflow/serialization/serialized_objects.py
@@ -1595,6 +1595,11 @@ class OperatorSerialization(DAGNode, BaseSerialization):
 elif field_name == "resources":
 return Resources.from_dict(value) if value is not None else None
 elif field_name.endswith("_date"):
+# Check if value is ARG_NOT_SET before trying to deserialize as 
datetime
+if isinstance(value, dict) and value.get(Encoding.TYPE) == 
DAT.ARG_NOT_SET:
+from airflow.serialization.definitions.notset import NOTSET
+
+return NOTSET
 return cls._deserialize_datetime(value) if value is not None else 
None
 else:
 # For all other fields, return as-is (strings, ints, bools, etc.)
diff --git 
a/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py 
b/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
index ae3f978da4..728a1cf5ba 100644
--- 
a/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
+++ 
b/providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
@@ -53,6 +53,7 @@ except ImportError:

 XCOM_LOGICAL_DATE_ISO = "trigger_logical_date_iso"
 XCOM_RUN_ID = "trigger_run_id"
+XCOM_DAG_ID = "trigger_dag_id"

 if TYPE_CHECKING:
@@ -85,21 +86,26 @@ class TriggerDagRunLink(BaseOperatorLink):
 if TYPE_CHECKING:
 assert isinstance(operator, TriggerDagRunOperator)

-trigger_dag_id = operator.trigger_dag_id
-if not AIRFLOW_V_3_0_PLUS:
-from airflow.models.renderedtifields import 
RenderedTaskInstanceFields
-from airflow.models.taskinstancekey import TaskInstanceKey as 
CoreTaskInstanceKey
-
-core_ti_key = CoreTaskInstanceKey(
-dag_id=ti_key.dag_id,
-task_id=ti_key.task_id,
-run_id=ti_key.run_id,
-try_number=ti_key.try_number,
-map_index=ti_key.map_index,
-)
+# Try to get the resolved dag_id from XCom first (for dynamic dag_ids)
+trigger_dag_id = XCom.get_value(ti_key=ti_key, key=XCOM_DAG_ID)
+
+# Fallback to operator attribute and rendered fields if not in XCom
+if not trigger_dag_id:
+trigger_dag_id = operator.trigger_dag_id
+if not AIRFLOW_V_3_0_PLUS:
+from airflow.models.renderedtifields import 
RenderedTaskInstanceFields
+from airflow.models.taskinstancekey import TaskInstanceKey as 
CoreTaskInstanceKey
+
+core_ti_key = CoreTaskInstanceKey(
+dag_id=ti_key.dag_id,
+task_id=ti_key.task_id,
+run_id=ti_key.run_id,
+try_number=ti_key.try_number,
+map_index=ti_key.map_index,
+)

-if template_fields := 
RenderedTaskInstanceFields.get_templated_fields(core_ti_key):
-trigger_dag_id: str = template_fields.get("trigger_dag_id", 
operator.trigger_dag_id)  # type: ignore[no-redef]
+if template_fields := 
RenderedTaskInstanceFields.get_templated_fields(core_ti_key):
+trigger_dag_id: str = 
template_fields.get("trigger_dag_id", operator.trigger_dag_id)  # type: 
ignore[no-redef]

 # Fetch the correct dag_run_id for the triggerED dag which is
 # stored in xcom during execution of the triggerING task.
@@ -203,7 +209,7 @@ class TriggerDagRunOperator(BaseOperator):
 self.openlineage_inject_parent_info = openlineage_inject_parent_info
 self.deferrable = deferrable
 self.logical_date = logical_date
-if logical_date is NOTSET:
+if isinstance(logical_date, ArgNotSet) or logical_date is NOTSET:
 self.logical_date = NOTSET
 elif logical_date is None or isinstance(logical_date, (str, 
datetime.datetime)):
 self.logical_date = logical_date
@@ -216,7 +222,7 @@ class TriggerD

[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-01-16 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
42163ddf327b026fdae344c9199780e51837281e / hwang-cadent 
Apply pre-commit formatting fix

Split long assertion line to comply with line length rules.

Report URL: https://github.com/apache/airflow/actions/runs/21070258503

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-01-14 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
93a667a93ef750491d1827ffc8d9781d6f808793 / hwang-cadent 
Fix test: require at least 1 GetDagRunState call instead of 2

The polling loop may complete in fewer calls depending on timing and
the DAG run state. Change the assertion to require at least 1 call
instead of exactly 2, which is more flexible and matches actual behavior.

Report URL: https://github.com/apache/airflow/actions/runs/21002316141

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-01-14 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
70635e17c5024e038b4cb166281f2b19d5de127b / hwang-cadent 
Fix flaky test_success in WasbBlobSensorTrigger and WasbPrefixSensorTrigger

The tests were failing because get_async_conn() was not mocked, causing
the async context manager to potentially block or take time to initialize.
This fix:
1. Mocks get_async_conn() to return an AsyncMock that works as an async context 
manager
2. Uses asyncio.wait_for() with a timeout instead of asyncio.sleep() to
   properly wait for the task to complete
3. Adds proper error handling for timeout cases

Report URL: https://github.com/apache/airflow/actions/runs/20999299076

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-01-14 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
270f02368e3aba626b9ea60e62477c828e73d73a / hwang-cadent 
Fix flaky test_success in WasbBlobSensorTrigger and WasbPrefixSensorTrigger

The tests were failing because get_async_conn() was not mocked, causing
the async context manager to potentially block or take time to initialize.
This fix:
1. Mocks get_async_conn() to return an AsyncMock that works as an async context 
manager
2. Uses asyncio.wait_for() with a timeout instead of asyncio.sleep() to
   properly wait for the task to complete
3. Adds proper error handling for timeout cases

Report URL: https://github.com/apache/airflow/actions/runs/20996808708

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-01-13 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
45d44b282d417c04559f7faa7f4e3652822de3ff / hwang-cadent 
Fix test assertions: include SetRenderedFields in expected calls

SetRenderedFields is sent before task execution, so it appears first
in the actual calls. Include it in the expected calls using mock.ANY
to allow assert_has_calls to match the sequence correctly.

Report URL: https://github.com/apache/airflow/actions/runs/20964883787

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-01-13 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
17ae6c20807a2883033bf4107da7cdec675b0868 / hwang-cadent 
Fix test assertions to use positional arguments for mock calls

The actual supervisor comms send() calls use positional arguments,
not keyword arguments with msg=. Update test expectations to match
the actual call format.

Report URL: https://github.com/apache/airflow/actions/runs/20961359907

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-01-12 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
6463b55e7164685810fc5b1bf22176240a13238c / hwang-cadent 
Update tests to include trigger_dag_id XCom push

The TriggerDagRunOperator now pushes trigger_dag_id to XCom before
triggering the DAG run. Update the test expectations to include this
additional SetXCom call.

Report URL: https://github.com/apache/airflow/actions/runs/20931931665

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-01-12 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
b19b2afb86ee710f05a09b4b629657226219c018 / hwang-cadent 
Fix deserialization of logical_date when it's NOTSET

When logical_date is NOTSET, it gets serialized as ARG_NOT_SET. During
deserialization, _deserialize_field_value was trying to deserialize it
as a datetime because the field name ends with '_date', causing
TypeError: ArgNotSet() takes no arguments.

This fix checks if the value is ARG_NOT_SET before trying to deserialize
it as a datetime, and returns NOTSET directly if it is.

Also fixes ruff formatting issues in test_trigger_dagrun.py.

Report URL: https://github.com/apache/airflow/actions/runs/20928896254

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2026-01-12 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
7f284d330d0f986a9da37e623330e8d4835103b6 / hwang-cadent 
fix: simplify import to match codebase pattern

- Import NOTSET and ArgNotSet directly from airflow.utils.types
- Matches pattern used in other provider files

Report URL: https://github.com/apache/airflow/actions/runs/20924710817

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2025-11-16 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
2c202241d878bf45688e39f9043486b05aa5e7ac / hwang-cadent 
Remove test-specific error handling from production code

Address reviewer feedback: Remove try-except blocks that were catching
ImportError/AttributeError for test environments. Tests should use mocking
instead of having special cases in production code.

- Remove try-except blocks around XCom.get_value() calls in get_link()
- Add proper XCom.get_value() mocking to all tests that call get_link()
- Ensure tests properly mock XCom behavior instead of relying on error handling

Report URL: https://github.com/apache/airflow/actions/runs/19407652147

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2025-11-15 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by hwang-cadent).

Head commit for run:
f2456d6f7e36ae3b519dd15c4b26fac5fc2dc1ff / hwang-cadent 
Remove test-specific error handling from production code

Address reviewer feedback: Remove try-except blocks that were catching
ImportError/AttributeError for test environments. Tests should use mocking
instead of having special cases in production code.

- Remove try-except blocks around XCom.get_value() calls in get_link()
- Add proper XCom.get_value() mocking to all tests that call get_link()
- Ensure tests properly mock XCom behavior instead of relying on error handling

Report URL: https://github.com/apache/airflow/actions/runs/19396352600

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2025-11-14 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by eladkal).

Head commit for run:
171401bc6f9c5a7d635af174895b1aecc3069ff2 / hwang-cadent 
Remove test-specific error handling from production code

Address reviewer feedback: Remove try-except blocks that were catching
ImportError/AttributeError for test environments. Tests should use mocking
instead of having special cases in production code.

- Remove try-except blocks around XCom.get_value() calls in get_link()
- Add proper XCom.get_value() mocking to all tests that call get_link()
- Ensure tests properly mock XCom behavior instead of relying on error handling

Report URL: https://github.com/apache/airflow/actions/runs/19373138355

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2025-11-13 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by jscheffl).

Head commit for run:
3cd7f95f1bae507d21239f286931e4ab605419b6 / hwang-cadent 
Remove test-specific error handling from production code

Address reviewer feedback: Remove try-except blocks that were catching
ImportError/AttributeError for test environments. Tests should use mocking
instead of having special cases in production code.

- Remove try-except blocks around XCom.get_value() calls in get_link()
- Add proper XCom.get_value() mocking to all tests that call get_link()
- Ensure tests properly mock XCom behavior instead of relying on error handling

Report URL: https://github.com/apache/airflow/actions/runs/19346155028

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2025-11-06 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by eladkal).

Head commit for run:
b6757a5dc495f374dfe34c61674d0e10de209efc / hwang-cadent 
<[email protected]>
Merge branch 'main' into fix-46402-trigger-dagrun-dynamic-dag-id-links

Report URL: https://github.com/apache/airflow/actions/runs/19137538436

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2025-11-05 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by uranusjr).

Head commit for run:
f30e5446611854566c8977899a43fce7c7a9fb36 / hwang-cadent 
<[email protected]>
Merge branch 'main' into fix-46402-trigger-dagrun-dynamic-dag-id-links

Report URL: https://github.com/apache/airflow/actions/runs/19117060181

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2025-11-04 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by eladkal).

Head commit for run:
4da41f4a2cde772231ea5a4caaff45a3de0584d9 / hwang-cadent 
Remove test-specific error handling from production code

Address reviewer feedback: Remove try-except blocks that were catching
ImportError/AttributeError for test environments. Tests should use mocking
instead of having special cases in production code.

- Remove try-except blocks around XCom.get_value() calls in get_link()
- Add proper XCom.get_value() mocking to all tests that call get_link()
- Ensure tests properly mock XCom behavior instead of relying on error handling

Report URL: https://github.com/apache/airflow/actions/runs/19077804534

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/fix-46402-trigger-dagrun-dynamic-dag-id-links): Workflow run "Tests" failed!

2025-11-02 Thread GitBox


The GitHub Actions job "Tests" on 
airflow.git/fix-46402-trigger-dagrun-dynamic-dag-id-links has failed.
Run started by GitHub user hwang-cadent (triggered by eladkal).

Head commit for run:
d024a4667548f8c41d2892eb02c829e15c18280c / hwang-cadent 
<[email protected]>
Merge branch 'main' into fix-46402-trigger-dagrun-dynamic-dag-id-links

Report URL: https://github.com/apache/airflow/actions/runs/19013928895

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]