Hello again,
Ok, now I've modified the patch so that a Label is used instead. Not sure if
the description headline is needed, but take a look and tell me what you
think.
-Knut Erik-
On 8/13/07, Knut Erik Teigen <[EMAIL PROTECTED]> wrote:
>
>
>
> On 8/13/07, Laszlo Pandy <[EMAIL PROTECTED]> wrote:
> >
> > Knut Erik Teigen wrote:
> > > Hello,
> > >
> > > This is my first patch for Jokosher, and actually the first time I've
> > > contributed code to an open source project. I'm a guitar player, and
> > > have been looking for a decent, lightweight recording app, and I'm
> > very
> > > pleased with Jokosher so far. Since my day gig is coding, I thought I
> > > might as well try to give something back to the project as well.
> > > Anyways, hope you agree with what I've done. It was mostly just to
> > > familiarize myself with the codebase and the tools you use.
> > >
> > > First, I've fixed bug #87850, changed tooltip "Edit this mixdown step
> > > settings" to "Edit settings for this mixdown step".
> > >
> > > Second, I've added a textview box with the description in it for the
> > > ExtensionManagerDialog. I found that nearly all the descriptions
> > didn't
> > > fit in the treeView, so I think it is better this way. Now even longer
> >
> > > descriptions are also possible.
> > >
> > > That's all for now, but expect to hear more from me:)
> > >
> > > Regards,
> > > Knut Erik Teigen
> > >
> > >
> >
> > I realize it is two months later, but I finally got a chance to look at
> > this patch. It is a good idea and something that needed to be done, but
> > I don't like the way it is implemented. Having an extra viewport around
> > the treeview puts a border around everything and sometimes makes a
> > scrollbar visible, both of which are ugly.
> >
> > Also I'm not sure the textview widget is the best idea, even though this
> > the GTK widget that is most obvious for this job. Because the text is
> > not editable, I would suggest using a multi-line GTK label. You can see
> > an example of this in my API search dialog in the Extension Console
> > extension. When you click on the name of the function, the documentation
> > comes up in a GTK label on the bottom of the treeview. Of course this
> > wasn't implemented when you originally submitted this patch.
> >
> > I'm sorry that I didn't respond earlier, but if you make the changes and
> > resubmit the patch, I'll accept it. Also you are very close to getting
> > the 3 patches needed for you to get an SVN account.
> >
> > Laszlo
> >
>
>
> Hello,
>
> Thanks for the feedback. I also noticed the scrollbar after I submitted
> the patch,
> and agree that it's ugly.
> I'll try to use a multi-line label instead, and resubmit the patch.
>
> -Knut Erik-
>
Index: Jokosher.glade
===
--- Jokosher.glade (revision 1459)
+++ Jokosher.glade (working copy)
@@ -824,6 +824,7 @@
+ 5
True
True
version 0.9
@@ -,9 +4445,10 @@
12
+ 353
True
False
- 12
+ 13
@@ -4479,6 +4481,86 @@
+
+ True
+ 0
+ 0.5
+ GTK_SHADOW_NONE
+
+
+
+ True
+ 0.5
+ 0.5
+ 1
+ 1
+ 0
+ 0
+ 0
+ 0
+
+
+
+ True
+ True
+ False
+
+
+
+ 100
+ True
+
+ False
+ False
+ GTK_JUSTIFY_LEFT
+ True
+ False
+ 0
+ 0
+ 0
+ 0
+ PANGO_ELLIPSIZE_NONE
+ -1
+ False
+ 0
+
+
+
+
+
+
+
+
+
+ True
+ Description
+ False
+ True
+ GTK_JUSTIFY_LEFT
+ False
+ False
+ 0.5
+ 0.5
+ 0
+ 0
+ PANGO_ELLIPSIZE_NONE
+ -1
+ False
+ 0
+
+
+ label_item
+
+
+
+
+ 0
+ False
+ True
+
+
+
+
True
False
Index: ExtensionManagerDialog.py
===
--- ExtensionManagerDialog.py (revision 1459)
+++ ExtensionManagerDialog.py (working copy)
@@ -7,7 +7,7 @@
#
#---
-import gtk.glade, pango
+import gtk.glade, gtk.gdk, pango
import Globals, Extension
import gettext
import os
@@ -41,11 +41,13 @@
self.dlg = self.wTree.get_widget("ExtensionManagerDialog")
self.tree = self.wTree.get_widget("treeviewExtensions")
+ self.eb = self.wTree.get_widget("descriptionEventBox")
+ self.description = self.wTree.get_widget("ExtensionDescription")
+ self.eb.modify_bg(gtk.STATE_NORMAL, gtk.gdk.color_parse("white"))
self.prefs_button = self.wTree.get_widget("buttonPreferences")
self.AddColumn("Enabled", 0, 'toggle')
- self.AddColumn("Name", 1, 'text', 25)
- self.AddColumn("Description", 2, 'text', 25)
+ self.AddColumn("Name", 1, 'text', 30)
self.AddColumn("Version", 3, 'text', 7)
self.mod
