Re: [jokosher-devel] [PATCH] Added description textview to ExtensionManagerDialog

2007-08-16 Thread Laszlo Pandy
Knut Erik Teigen wrote:
 Hello again,
 
 Ok, now I've modified the patch so that a Label is used instead. Not sure if
 the description headline is needed, but take a look and tell me what you 
 think.
 
 -Knut Erik-

Committed, thanks.

Laszlo
___
jokosher-devel-list mailing list
jokosher-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/jokosher-devel-list


Re: [jokosher-devel] [PATCH] Added description textview to ExtensionManagerDialog

2007-08-15 Thread Knut Erik Teigen
Hello again,

Ok, now I've modified the patch so that a Label is used instead. Not sure if
the description headline is needed, but take a look and tell me what you
think.

-Knut Erik-

On 8/13/07, Knut Erik Teigen [EMAIL PROTECTED] wrote:



 On 8/13/07, Laszlo Pandy [EMAIL PROTECTED] wrote:
 
  Knut Erik Teigen wrote:
   Hello,
  
   This is my first patch for Jokosher, and actually the first time I've
   contributed code to an open source project. I'm a guitar player, and
   have been looking for a decent, lightweight recording app, and I'm
  very
   pleased with Jokosher so far. Since my day gig is coding, I thought I
   might as well try to give something back to the project as well.
   Anyways, hope you agree with what I've done. It was mostly just to
   familiarize myself with the codebase and the tools you use.
  
   First, I've fixed bug #87850, changed tooltip Edit this mixdown step
   settings to Edit settings for this mixdown step.
  
   Second, I've added a textview box with the description in it for the
   ExtensionManagerDialog. I found that nearly all the descriptions
  didn't
   fit in the treeView, so I think it is better this way. Now even longer
 
   descriptions are also possible.
  
   That's all for now, but expect to hear more from me:)
  
   Regards,
   Knut Erik Teigen
  
  
 
  I realize it is two months later, but I finally got a chance to look at
  this patch. It is a good idea and something that needed to be done, but
  I don't like the way it is implemented. Having an extra viewport around
  the treeview puts a border around everything and sometimes makes a
  scrollbar visible, both of which are ugly.
 
  Also I'm not sure the textview widget is the best idea, even though this
  the GTK widget that is most obvious for this job. Because the text is
  not editable, I would suggest using a multi-line GTK label. You can see
  an example of this in my API search dialog in the Extension Console
  extension. When you click on the name of the function, the documentation
  comes up in a GTK label on the bottom of the treeview. Of course this
  wasn't implemented when you originally submitted this patch.
 
  I'm sorry that I didn't respond earlier, but if you make the changes and
  resubmit the patch, I'll accept it. Also you are very close to getting
  the 3 patches needed for you to get an SVN account.
 
  Laszlo
 


 Hello,

 Thanks for the feedback. I also noticed the scrollbar after I submitted
 the patch,
 and agree that it's ugly.
 I'll try to use a multi-line label instead, and resubmit the patch.

 -Knut Erik-

Index: Jokosher.glade
===
--- Jokosher.glade	(revision 1459)
+++ Jokosher.glade	(working copy)
@@ -824,6 +824,7 @@
 /widget
 
 widget class=GtkAboutDialog id=AboutDialog
+  property name=border_width5/property
   property name=visibleTrue/property
   property name=destroy_with_parentTrue/property
   property name=name translatable=yesversion 0.9/property
@@ -,9 +4445,10 @@
   child
 widget class=GtkVBox id=vbox20
   property name=border_width12/property
+  property name=height_request353/property
   property name=visibleTrue/property
   property name=homogeneousFalse/property
-  property name=spacing12/property
+  property name=spacing13/property
 
   child
 	widget class=GtkScrolledWindow id=scrolledwindow4
@@ -4479,6 +4481,86 @@
   /child
 
   child
+	widget class=GtkFrame id=frame15
+	  property name=visibleTrue/property
+	  property name=label_xalign0/property
+	  property name=label_yalign0.5/property
+	  property name=shadow_typeGTK_SHADOW_NONE/property
+
+	  child
+	widget class=GtkAlignment id=alignment29
+	  property name=visibleTrue/property
+	  property name=xalign0.5/property
+	  property name=yalign0.5/property
+	  property name=xscale1/property
+	  property name=yscale1/property
+	  property name=top_padding0/property
+	  property name=bottom_padding0/property
+	  property name=left_padding0/property
+	  property name=right_padding0/property
+
+	  child
+		widget class=GtkEventBox id=descriptionEventBox
+		  property name=visibleTrue/property
+		  property name=visible_windowTrue/property
+		  property name=above_childFalse/property
+
+		  child
+		widget class=GtkLabel id=ExtensionDescription
+		  property name=height_request100/property
+		  property name=visibleTrue/property
+		  property name=label translatable=yes/property
+		  property name=use_underlineFalse/property
+		  property name=use_markupFalse/property
+		  property name=justifyGTK_JUSTIFY_LEFT/property
+		  property name=wrapTrue/property
+		  property name=selectableFalse/property
+		  property name=xalign0/property
+		  property name=yalign0/property
+		  property name=xpad0/property
+		  property name=ypad0/property
+		  property name=ellipsizePANGO_ELLIPSIZE_NONE/property
+		  

Re: [jokosher-devel] [PATCH] Added description textview to ExtensionManagerDialog

2007-08-12 Thread Laszlo Pandy
Knut Erik Teigen wrote:
 Hello,
 
 This is my first patch for Jokosher, and actually the first time I've 
 contributed code to an open source project. I'm a guitar player, and 
 have been looking for a decent, lightweight recording app, and I'm very 
 pleased with Jokosher so far. Since my day gig is coding, I thought I 
 might as well try to give something back to the project as well.
 Anyways, hope you agree with what I've done. It was mostly just to 
 familiarize myself with the codebase and the tools you use.
 
 First, I've fixed bug #87850, changed tooltip Edit this mixdown step 
 settings to Edit settings for this mixdown step.
 
 Second, I've added a textview box with the description in it for the 
 ExtensionManagerDialog. I found that nearly all the descriptions didn't 
 fit in the treeView, so I think it is better this way. Now even longer 
 descriptions are also possible.
 
 That's all for now, but expect to hear more from me:)
 
 Regards,
 Knut Erik Teigen
 
 

I realize it is two months later, but I finally got a chance to look at 
this patch. It is a good idea and something that needed to be done, but 
I don't like the way it is implemented. Having an extra viewport around 
the treeview puts a border around everything and sometimes makes a 
scrollbar visible, both of which are ugly.

Also I'm not sure the textview widget is the best idea, even though this
the GTK widget that is most obvious for this job. Because the text is 
not editable, I would suggest using a multi-line GTK label. You can see 
an example of this in my API search dialog in the Extension Console 
extension. When you click on the name of the function, the documentation 
comes up in a GTK label on the bottom of the treeview. Of course this 
wasn't implemented when you originally submitted this patch.

I'm sorry that I didn't respond earlier, but if you make the changes and 
resubmit the patch, I'll accept it. Also you are very close to getting 
the 3 patches needed for you to get an SVN account.

Laszlo
___
jokosher-devel-list mailing list
jokosher-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/jokosher-devel-list