Re: [josm-dev] Request for review of plugins

2014-02-27 Thread Paul Hartmann
On 02/26/2014 10:08 PM, Simon Legner wrote: On 26/02/14 21:58, Marián Kyral wrote: Thanks Simon. It fixes the first case (when there is a local git repository inside the plugin folder). But it still fails when there is no .git folder at all. Right, but what should be the outcome? How to

Re: [josm-dev] Request for review of plugins

2014-02-26 Thread Marián Kyral
Dne 25.2.2014 16:13, Dirk Stöcker napsal: On Tue, 25 Feb 2014, Marián Kyral wrote: Feel free to improve it... But I don't know how :-( You can do so, when you know it :-) I have official svn copy and I've created a new plugin folder. Git is used only inside pointInfo folder. What I

Re: [josm-dev] Request for review of plugins

2014-02-26 Thread Simon Legner
Hi, On 25/02/14 12:55, Dirk Stöcker wrote: ... or fix the build-common.xml. When reading the text it tells me, that svn should fail and git be used instead. Seems your svn does not fail enough? It probably delivers something. Maybe a check is needed to detect that invalid output? Done:

Re: [josm-dev] Request for review of plugins

2014-02-26 Thread Simon Legner
On 26/02/14 21:58, Marián Kyral wrote: Thanks Simon. It fixes the first case (when there is a local git repository inside the plugin folder). But it still fails when there is no .git folder at all. Right, but what should be the outcome? How to determine the last change timestamp? I won't

[josm-dev] Request for review of plugins

2014-02-25 Thread Marián Kyral
Hi all, some time before I've started with plugin development. Initially I only wanted to change the hardcoded server URL in the Tracer plugin (http://wiki.openstreetmap.org/wiki/JOSM/Plugins/Tracer). But then it started to growth ;-) The original Trace plugin traces buildings (and other

Re: [josm-dev] Request for review of plugins

2014-02-25 Thread Dirk Stöcker
On Tue, 25 Feb 2014, Marián Kyral wrote: Both plugins were discussed and tested by Czech OSM community (talk-cz@) and are regularly used by several users. I think that now are both plugins stable enough to include them in JOSM repository (and fix the annoying missing version issue). See

Re: [josm-dev] Request for review of plugins

2014-02-25 Thread Marián Kyral
Dne 25.2.2014 10:34, Dirk Stöcker napsal: On Tue, 25 Feb 2014, Marián Kyral wrote: Both plugins were discussed and tested by Czech OSM community (talk-cz@) and are regularly used by several users. I think that now are both plugins stable enough to include them in JOSM repository (and fix the

Re: [josm-dev] Request for review of plugins

2014-02-25 Thread Dirk Stöcker
On Tue, 25 Feb 2014, Marián Kyral wrote: https://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins Yes, I read this page, several times ;-) I think, it needs some improvements. E.g.: how to handle version in manifest for new plugin without commit to svn (se below). Feel free to

Re: [josm-dev] Request for review of plugins

2014-02-25 Thread Marián Kyral
Dne 25.2.2014 12:55, Dirk Stöcker napsal: On Tue, 25 Feb 2014, Marián Kyral wrote: https://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins Yes, I read this page, several times ;-) I think, it needs some improvements. E.g.: how to handle version in manifest for new plugin

Re: [josm-dev] Request for review of plugins

2014-02-25 Thread Dirk Stöcker
On Tue, 25 Feb 2014, Marián Kyral wrote: Feel free to improve it... But I don't know how :-( You can do so, when you know it :-) I have official svn copy and I've created a new plugin folder. Git is used only inside pointInfo folder. What I get: [...snip...] This looks much like a