Re: [josm-dev] connected nodes in blue

2009-04-24 Thread Henrik Niehaus
Ulf Lamping schrieb: I thought a bit about it, but I have no idea how to implement it in a good way. I had a look at the DataSet class and I would suggest to extend it with DataSetChanged listeners. Fortunately the class uses the interface Collection, so that the LinkedLists containing

[josm-dev] JOSM-NG and eclipse rcp

2009-04-24 Thread Frederik Fischer
Hi, i wonder if anyone considered (and evaluated) the usage of the eclipse rcp framework for a josm-ng implementation. If yes, do you see any problems with using the eclipse rcp? Recently i spent some days to build a simple josm-ng protoype [1][2] using the eclipse rcp framework. In my opinion

Re: [josm-dev] Commit message not empty

2009-04-24 Thread Martin Koppenhoefer
2009/4/24 Richard Fairhurst rich...@systemed.net: Potlatch writes comments as part of the _close_ changeset option. But you can't enforce it because there's no way to stop someone closing their browser or, in extremis, turning off their computer. why is it crucial to the concept of Potlatch to

Re: [josm-dev] Commit message not empty

2009-04-24 Thread Richard Fairhurst
Martin Koppenhoefer wrote: why is it crucial to the concept of Potlatch to upload every modification directly and just-in-time? Wouldn't it be suitable as well to have an upload-button and just upload changes made on explicit request? See my other message:

Re: [josm-dev] Commit message not empty

2009-04-24 Thread Ulf Lamping
Richard Fairhurst schrieb: Ulf Lamping wrote: There is *no* problem to add a changeset to an online editor. This is simply just another indication that the potlatch model of not having a Save button is the wrong way to go IMHO. For the record this isn't the potlatch model. It's the Java

Re: [josm-dev] Commit message not empty

2009-04-24 Thread Richard Fairhurst
Ulf Lamping wrote: Well, to be honest I'm not convinced that conflict management is that important. I got only two or three conflicts in my 2-3 OSM years and I have edited the OSM data a lot (in Nürnberg, where other mappers are also active). That means roughly 1 conflict per year

Re: [josm-dev] Commit message not empty

2009-04-24 Thread Matt Amos
On Fri, Apr 24, 2009 at 6:05 PM, Richard Fairhurst rich...@systemed.net wrote: Well, in reality Potlatch can put any comment where the hell it likes because it's not hidebound by the XML API that you poor saps have to labour under... and, in reality, so can JOSM. the XML api doesn't require a

Re: [josm-dev] Commit message not empty

2009-04-24 Thread Frederik Ramm
Hi, Matt Amos wrote: On Fri, Apr 24, 2009 at 6:05 PM, Richard Fairhurst rich...@systemed.net wrote: Well, in reality Potlatch can put any comment where the hell it likes because it's not hidebound by the XML API that you poor saps have to labour under... and, in reality, so can JOSM. the

Re: [josm-dev] Commit message not empty

2009-04-24 Thread Richard Fairhurst
Matt Amos wrote: of course, if what you meant was that because you write the potlatch api you can reach into the guts of the database and fiddle with changesets after they're closed... well... :-P Don't get too excited. I can commit whatever evil stuff I like, but Tom has the final say over

Re: [josm-dev] Commit message not empty

2009-04-24 Thread Matt Amos
On Fri, Apr 24, 2009 at 11:02 PM, Frederik Ramm frede...@remote.org wrote: Matt Amos wrote: On Fri, Apr 24, 2009 at 6:05 PM, Richard Fairhurst rich...@systemed.net wrote: Well, in reality Potlatch can put any comment where the hell it likes because it's not hidebound by the XML API that you