Hi, One thing that always annoyed me about JOSM is that it has those many modal dialogs. In other editors, you can simply fill in the key/value table, in JOSM you always need to double-click on the value, then move your mouse and click on the position where you want to edit the value (assuming you want to fix a typo). Then you need to explicitly confirm that dialog by pressing Enter.
The current implementation of the tags table is not that clean as well (PropertiesDialog), the whole table model is coded there. There is a nice and relatively clean tag editor table that is currently used for relations and changesets. It supports inline editing using autocomplete text fields. The TagCellEditor is currently already added to the second column of the table (but not the key column), but it cannot be used because all table cells are set to uneditable. Has there been any work on using this as a feature for the tags panel on the right? It would make the code cleaner and improve usability. Those are the difficulties I see with it: * Currently, JOSM keyboard events are global to the window, we need to disable them as long as the table is edited. * We should use double-clicking for editing (currently, a single click edits keys and values). * The table model might need to be changed to support some nicer way of auto-completion. We could include the combo box already used in presets here. * We need the table model to fire change events as soon as any key/value is changed. Currently, it only supports bulk changes. * The model does support different values per key, but it does not count them. This needs to be changed. What are your thoughts on it? Has there alreardy been someone working on this? If that change is desired, I will spend some time writing a patch for changing the table. Michael _______________________________________________ josm-dev mailing list josm-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/josm-dev
