Re: [josm-dev] Critical bug since 2204
Running unit tests should be compulsory with every code check-in. We should also consider to force having unit tests for all new added packages! Kind Regards, Dieter On 6 Oct 2009, at 00:15, Karl Guggisberg wrote: Hi everybody since 2204 there was a critical bug in Way. It broke the merge logic (the unit tests for MergeVisitor didn't pass). It is still present in tested (2221) and users will certainly notice because conflicts on ways are not detected as expected. Shouldn't running all unit tests be part of the build process, at least before a tested release is published? Regards Karl ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Critical bug since 2204
Hi, Dieter Muecke wrote: Running unit tests should be compulsory with every code check-in. We should also consider to force having unit tests for all new added packages! -1 Bye Frederik ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Critical bug since 2204
Hi everybody since 2204 there was a critical bug in Way. It broke the merge logic (the unit tests for MergeVisitor didn't pass). It is still present in tested (2221) and users will certainly notice because conflicts on ways are not detected as expected. Shouldn't running all unit tests be part of the build process, at least before a tested release is published? Regards Karl ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Critical bug since 2204
On Tue, Oct 6, 2009 at 12:15 AM, Karl Guggisberg karl.guggisb...@guggis.ch wrote: It is still present in tested (2221) and users will certainly notice because conflicts on ways are not detected as expected. I tried on my build version and merging ways seems to work. Which type of conflicts are not detected ? Pieren ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
