[jquery-dev] Re: a bug in jQuery.fn.ready

2009-12-16 Thread helianthus
OK I just found out why. One of my project is a cross-browser userscript. Since GreaseMonkey runs userscripts only after the DOM is ready, I set jQuery.isReady to true when GreaseMonkey is detected, and that causes the function stacks never fired. Now I realize jQuery.ready() is probably the corre

Re: [jquery-dev] Re: a bug in jQuery.fn.ready

2009-12-16 Thread John Resig
It shouldn't make much difference either way but I moved the check. The result should be a bit clearer now: http://github.com/jquery/jquery/commit/9a0174b057ae58735c3c5f595e420c7bb1db038c --John On Wed, Dec 16, 2009 at 11:02 PM, helianthus wrote: > But my code broke after switching from 1.4a1

[jquery-dev] Re: a bug in jQuery.fn.ready

2009-12-16 Thread helianthus
But my code broke after switching from 1.4a1 to 1.4a2... and removing that check fixed it. I guess I have to check again what broke my code then. On Dec 17, 11:25 am, John Resig wrote: > That's not true - readyList is set to null inside of jQuery.ready() > once the queue has been emptied (the log