Re: [Jruby-devel] devnull patch

2006-06-30 Thread Charles O Nutter
The /dev/null thing is a hack, pure and simple. Consider it apart from the other fixes Tom mentioned, since those are all valid.So it's a hack...the alternative is reporting an appropriate platform so that it doesn't try to user devnull on Windows, as has been mentioned. However... Java is not Wind

Re: [Jruby-devel] devnull patch

2006-06-30 Thread Evan Buswell
What issues are there for just changing platform to "win32" / "linux" / etc instead of "java"? I haven't looked into all this, so forgive my ignorance, but hacking a "/dev/null" open to a custom IO call just seems like fixing what isn't the problem.  Rails checks the platform and opens the right f

Re: [Jruby-devel] devnull patch

2006-06-30 Thread Thomas E Enebo
On Fri, 30 Jun 2006, Thomas E Enebo defenestrated me: > (though it is still outputting requests to stdout which I think should > be in the log file -- so even with these fixes that did not straighten > out). I take this back...it works the same as Ruby -Tom -- + http://www.tc.umn.edu/~ene

Re: [Jruby-devel] devnull patch

2006-06-30 Thread Thomas E Enebo
On Fri, 30 Jun 2006, Charles O Nutter defenestrated me: > >I'll have a look. A few comments inline below. > >On 6/29/06, Thomas E Enebo <[EMAIL PROTECTED]> wrote: > > On Thu, 29 Jun 2006, Charles O Nutter defenestrated me: > > > >Whee! >I needed to do a surpris

Re: [Jruby-devel] devnull patch

2006-06-29 Thread Charles O Nutter
I'll have a look. A few comments inline below.On 6/29/06, Thomas E Enebo <[EMAIL PROTECTED]> wrote: On Thu, 29 Jun 2006, Charles O Nutter defenestrated me:>>Whee!  I needed to do a surprising additional number of things toget rails silence_stderr working with this patch.  Here is a break- down:

Re: [Jruby-devel] devnull patch

2006-06-29 Thread Thomas E Enebo
On Thu, 29 Jun 2006, Charles O Nutter defenestrated me: > >Whee! I needed to do a surprising additional number of things to get rails silence_stderr working with this patch. Here is a break- down: 1. reopen with string as first arg should retain permissions/modes of IO it is reopening