Reminder: Leaving code better than you find it.

2016-07-19 Thread Tim Penhey
Hi all, I'd like to reiterate a key tenet [1] for the core team, and that is "leave the code better than you found it" Often we get too focused on the one thing we are trying to land, and disregard other small fixes or changes that could be made to make the code better. I'm not saying

Proposed addition to code review guidelines

2016-07-19 Thread Tim Penhey
Hi folks, With model migration entering the world as a first class citizen, we need to ensure that all fields and documents added to state have appropriate migrations done for them. In particular when adding a field it is likely that the state/migrations_internal_test.go will have a failing

[Review Queue] Nexenta Edge Suite

2016-07-19 Thread Charles Butler
Greetings Anton, I took a moment to take a look today and they were +1 LGTM and have pushed your proposed changes to the nexenta edge charms. The following is the result of the review/publication cycle: url: cs:~nexenta-charmers/trusty/nexentaedge-iscsi-gw-4 channel: stable url:

Re: Charm push crashes when uploading big charms

2016-07-19 Thread Tom Barber
Okay bzip -9'ed it, down to 760mb and tried to attach it via my server in a data centre... same failure. Tom -- Director Meteorite.bi - Saiku Analytics Founder Tel: +44(0)5603641316 (Thanks to the Saiku community we reached our Kickstart

Re: Charm push crashes when uploading big charms

2016-07-19 Thread Tom Barber
Yeah, but in life, i can ftp/sftp/http upload a file to a.n.other service without a timeout irrespective of size. Clearly it will take a long time on crappy FTTC ADSL but it does work and doesn't timeout :) -- Director Meteorite.bi - Saiku Analytics Founder Tel: +44(0)5603641316

Re: Charm push crashes when uploading big charms

2016-07-19 Thread José Antonio Rey
Oh! Huh. Then maybe it is a size constraint :) On Tue, Jul 19, 2016, 01:48 Tom Barber wrote: > Yeah, but you could also argue this hotel wifi is a lot quicker than my > home wifi, so it still seems a bit flawed if you need to push from fast > pipes! Anyway I shall try

Re: Charm push crashes when uploading big charms

2016-07-19 Thread Tom Barber
Yeah, but you could also argue this hotel wifi is a lot quicker than my home wifi, so it still seems a bit flawed if you need to push from fast pipes! Anyway I shall try and find out. Tom -- Director Meteorite.bi - Saiku Analytics Founder Tel: +44(0)5603641316 (Thanks to the Saiku

Re: Charm push crashes when uploading big charms

2016-07-19 Thread José Antonio Rey
Hotel wifi may be the problem. Maybe try uploading it to a server with a fast upload speed, and then pusing from that server instead? On 07/19/2016 01:33 AM, Tom Barber wrote: 825mb on hotel wifi Rick, I'll squash it further and try again on data centre pipes. Tom -- Director

Re: Charm push crashes when uploading big charms

2016-07-19 Thread Tom Barber
825mb on hotel wifi Rick, I'll squash it further and try again on data centre pipes. Tom -- Director Meteorite.bi - Saiku Analytics Founder Tel: +44(0)5603641316 (Thanks to the Saiku community we reached our Kickstart