Greetings. Konstantinos, Pete, and I reviewed some items from the RQ today. We also forgot to send out notification of some reviews we did the week before last.
Aug 4, 2016: Cory/Konstantinos/Pete - Nagios - cross platform support (centos) - https://code.launchpad.net/~dbuliga/charms/trusty/nagios/nagios/+merge/288614 - Use the platform parameter sent from NRPE in the 'monitors' relation to set the host icon and text. - The code review of the patch was fine. Running the amulet tests gave out some errors that are probably not caused by the patch at hand. Yet they need to be addressed. - Pubphoto - https://bugs.launchpad.net/charms/+bug/1574772 - This is a pubphoto revision for trusty. - This was the second round of review of this charm. The authors addressed the minor comments that we had. - +1 for promulgation (https://jujucharms.com/u/jose/pubphoto/trusty/1) - Apache2 -- add juju storage support - https://code.launchpad.net/~canonical-sysadmins/charms/trusty/apache2/apache2-storage/+merge/298617 - “make test” fails, as new code breaks a mock in the existing tests. - Code looks good, other tests pass, and manual deploy works. +1 after make test is fixed. - nrpe-external-master - https://code.launchpad.net/~aluria/charms/precise/nrpe-external-master/donotremove-hostdefs/+merge/290957 - Has been +1’d but it might be deprecated in favor of nrpe, or might need the repo / charm store namespace updated to reflect new policies. July 21, 2016: Cory/Kevin/Pete - couchbase (trusty) - https://bugs.launchpad.net/charms/+bug/1603300 - A few tests are failing. Made notes and set status as incomplete’ - Kibana - https://bugs.launchpad.net/charms/+bug/1603181 - Linter fails, and one depoy test fails. Made notes and set status as ‘incomplete’ - Conjure-up spells - This is a bit self-serving, but we really wanted to kick the tires with bigdata spells - https://github.com/juju-solutions/bundle-apache-processing-mapreduce/pull/8 - https://github.com/juju-solutions/bundle-realtime-syslog-analytics/pull/7 - Minor comments are being addressed, but in general, these are working great!
-- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju