Re: Feedback on a base fake type in the testing repo

2015-02-13 Thread Gustavo Niemeyer
On Fri, Feb 13, 2015 at 2:05 PM, Eric Snow eric.s...@canonical.com wrote: As for me, by fake I mean a struct that implements an interface with essentially no logic other than to keep track of method calls and facilitate controlling their return values explicitly. For examples see the

Re: problem with amulet and ssh

2015-02-13 Thread Stuart Bishop
On 13 February 2015 at 09:42, Nicolás Pace nicop...@gmail.com wrote: Hi guys, I'm having a problem with amulet. i implemented a test with this chunk of code inside: logstash_indexer_agent = d.sentry.unit['logstash-indexer/0'] curl_response = logstash_indexer_agent.run(curl

Re: Feedback on a base fake type in the testing repo

2015-02-13 Thread Gustavo Niemeyer
On Fri, Feb 13, 2015 at 3:25 PM, Eric Snow eric.s...@canonical.com wrote: This is a mock object under some well known people's terminology [1]. With all due respect to Fowler, the terminology in this space is fairly muddled still. :) Sure, I'm happy to use any terminology, but I'd prefer to

Re: problem with amulet and ssh

2015-02-13 Thread Marco Ceppi
Thanks Nicolás for brining this to our attention and Stuart for shedding light on how deep this bug runs. While it's true we're kind of tied to doing what Juju does, that doesn't mean we can't look at ways to alleviate this in Amulet to avoid tests to prevent them from failing. On Fri, Feb 13,

Re: Feedback on a base fake type in the testing repo

2015-02-13 Thread Gustavo Niemeyer
On Fri, Feb 13, 2015 at 6:50 PM, Eric Snow eric.s...@canonical.com wrote: Using a fake for that input means you don't have to encode the low-level business logic in each test (just any setup of the fake's state). You can be confident about the low-level behavior during tests as matching

Start/Stop machines

2015-02-13 Thread Jorge Niedbalski
Hello, Does anybody is aware of a blueprint or WIP for implementing cross-provider machine start/stop operations ? This would be really useful for suspend/resuming environments. We are currently using this plugin (https://github.com/niedbalski/juju-suspend) but would be nice to have a proper

[Review Queue]: mysql x 2, elasticsearch

2015-02-13 Thread Kevin Monroe
Hey folks, Amir, Cory, and I tackled a few reviews in the queue: + mysql (shared-db refactor) https://code.launchpad.net/~hopem/charms/trusty/mysql/contrib-database-mysql/+merge/248743 Cory manually deployed and related to the lamp charm to exercise this relation. It looks good, so we think