That's really great!
John
=:-
On Fri, Apr 24, 2015 at 1:59 PM, Gabriel Samfira
gsamf...@cloudbasesolutions.com wrote:
That is great news! Congrats guys! :)
Cheers,
Gabriel
From: juju-dev-boun...@lists.ubuntu.com
That is great news! Congrats guys! :)
Cheers,
Gabriel
From: juju-dev-boun...@lists.ubuntu.com [juju-dev-boun...@lists.ubuntu.com] on
behalf of Martin Packman [martin.pack...@canonical.com]
Sent: Friday, April 24, 2015 12:56 PM
To:
On 23/04/2015, Martin Packman martin.pack...@canonical.com wrote:
Well, mostly good news after Matty and I landed workarounds. There's a
single remaining failure that has manifested since:
TestLeadership fails on windows test slave
https://bugs.launchpad.net/juju-core/+bug/1447595
With
There's a very useful pre-push hook available for juju that does useful
things like run gofmt, go vet, checks we can build etc.
If you don't have it setup there's some lovely instructions in
Contributing.md:
https://github.com/juju/juju/blob/master/CONTRIBUTING.md#local-clone
Thanks for
I wasn't able to work out why my test failed on windows, but I was able to
realise that it wasn't really testing what I wanted. I'm landing a further
change now that makes the tests a little better, and adds a new one, and
I've confirmed that they pass in the right way on windows and ubuntu.
Why doesn't the bot run this hook ?
On Fri, Apr 24, 2015 at 9:54 PM, Matthew Williams
matthew.willi...@canonical.com wrote:
There's a very useful pre-push hook available for juju that does useful
things like run gofmt, go vet, checks we can build etc.
If you don't have it setup there's some
2015-04-23 20:31 GMT+03:00 roger peppe roger.pe...@canonical.com:
Ah! After looking at your code, I think I might know what your
question means. Do you mean If I call RegisterRelation, why
does gocharm not generate relation hooks for that relation?.
If so, the answer is that gocharm only
2015-04-23 20:31 GMT+03:00 roger peppe roger.pe...@canonical.com:
Ah! After looking at your code, I think I might know what your
question means. Do you mean If I call RegisterRelation, why
does gocharm not generate relation hooks for that relation?.
If so, the answer is that gocharm only
On 24/04/2015, David Cheney david.che...@canonical.com wrote:
Why doesn't the bot run this hook ?
It does - but there are two problems:
1) For the gating job to reject the change, the script just has not
return non-zero. Seems `go tool vet` returns 0 even if it reports
issues. So,
This is awesome! Thank you.
On Fri, Apr 24, 2015 at 8:34 AM, Cory Johns cory.jo...@canonical.com
wrote:
Last week, while in Nuremberg, Ben and I were able to create a new
plugin to enable a much better charm development workflow.
Once the Juju Plugins bundle (https://github.com/juju/plugins)
Hello all. Kevin and I reviewed the following charms yesterday:
* websphere base
https://bugs.launchpad.net/charms/+bug/1446966
In addition to a few small concerns, such as using the template icon,
we noted some immutable config and ran into trouble testing the charm
due to not being able to
Last week, while in Nuremberg, Ben and I were able to create a new
plugin to enable a much better charm development workflow.
Once the Juju Plugins bundle (https://github.com/juju/plugins) is
installed, you can now run `juju sync-watch unit` to enable local
editing of a remote charm. This works
This is nothing but pure awesome in plugin form! Thanks for working on this
On Fri, Apr 24, 2015 at 8:34 AM Cory Johns cory.jo...@canonical.com wrote:
Last week, while in Nuremberg, Ben and I were able to create a new
plugin to enable a much better charm development workflow.
Once the Juju
Sorry. I was not clear.
Why isn't the bot running the pre-commit hook as part of the CI test ?
What we have now is a warning, gleefully ignored.
What we need is an error, which rejects the PR if it doesn't pass the
pre-commit hook.
On Fri, Apr 24, 2015 at 10:28 PM, John Meinel
On 24 April 2015 at 14:33, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2015-04-23 20:31 GMT+03:00 roger peppe roger.pe...@canonical.com:
Ah! After looking at your code, I think I might know what your
question means. Do you mean If I call RegisterRelation, why
does gocharm not generate relation
On 24 April 2015 at 14:21, Martin Packman martin.pack...@canonical.com wrote:
On 24/04/2015, David Cheney david.che...@canonical.com wrote:
Why doesn't the bot run this hook ?
It does - but there are two problems:
1) For the gating job to reject the change, the script just has not
return
On 24 April 2015 at 14:33, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2015-04-23 20:31 GMT+03:00 roger peppe roger.pe...@canonical.com:
Ah! After looking at your code, I think I might know what your
question means. Do you mean If I call RegisterRelation, why
does gocharm not generate relation
On 24/04/2015, roger peppe roger.pe...@canonical.com wrote:
Are you sure? It seems to return a non-zero exit status for me.
I guess you're not using ubuntu packaged go, but something trunkier?
I guess it (and the other point) might be a consequence of running
a different version of govet.
$
Re-review xCAT
https://bugs.launchpad.net/charms/+bug/1441622
New Review:
WebSphere Application Server Base
https://bugs.launchpad.net/charms/+bug/1446966
WebSphere Application Server Network Deploy
https://bugs.launchpad.net/charms/+bug/1446999
Johnny
Congratulations Domas!
On 23 Apr 2015 15:47, Casey Marshall casey.marsh...@canonical.com wrote:
Juju developers,
I would like to announce Domas Monkus is a fully graduated Juju core
reviewer. This announcement is really long overdue.. Domas is careful
and thoughtful in his reviews, his
Thanks!
Thank you, Casey and Dimiter for reviewing my reviews all this time!
Domas
On Fri, Apr 24, 2015 at 10:23 AM, Matthew Williams
matthew.willi...@canonical.com wrote:
Congratulations Domas!
On 23 Apr 2015 15:47, Casey Marshall casey.marsh...@canonical.com
wrote:
Juju developers,
I
2015-04-24 18:14 GMT+03:00 roger peppe roger.pe...@canonical.com:
I don't, but someone else here might :)
Canonical does not have such plans ?=)
Thanks for help! Have a nice day.
--
Vasiliy Tolstov,
e-mail: v.tols...@selfip.ru
jabber: v...@selfip.ru
--
Juju mailing list
22 matches
Mail list logo
