Hello All, Today we are announcing some updates to the review process for PRs submitted to the juju/juju project. The core development team has composed a review checklist:
https://github.com/juju/juju/wiki/Code-Review-Checklists There is guidance <https://github.com/juju/juju/wiki/Code-Review-Checklists#using-the-checklists> [1] on using the checklist new the top of the page. The goal of the checklist is to ensure a base level of quality and assist reviewers evaluating pull requests. Please leverage this checklist when reviewing PRs. Additionally, note in your review that you have run through the relevant areas of the checklist as part of the review. Along with reviewers using the checklist, committers of PRs are now required to add a *QA *section to their commit. The *QA* section should outline the steps used to live test the changes in the PR. It should include both the steps used for testing and expected outcome. Any commit not including a *QA* section will not pass review. Feedback on the new process and checklist is welcome. Happy coding, testing and reviewing! --Alexis [1] https://github.com/juju/juju/wiki/Code-Review-Checklists#using-the-checklists -- Alexis Bruemmer Juju Core Manager, Canonical Ltd. (503) 686-5018 alexis.bruem...@canonical.com
-- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
