Re: Maximum AllWatcher frame size?

2017-06-14 Thread Cory Johns
So, I'm not sure if this resolves the issue. The python websockets library supports fragmented messages but I think that is separate from the maximum message size that it's enforcing. I think that maximum is for the final payload, which would be the entire AllWatcher JSON response. If the

Re: Maximum AllWatcher frame size?

2017-06-14 Thread Cory Johns
Do we know what size the gorilla/websocket library uses for automatic chunking? On Wed, Jun 14, 2017 at 11:35 AM, John Meinel wrote: > In 2.1 we did not chunk, in 2.2 we switch to gorilla/websocket which does > support chunking into frames. I don't think we do any

Re: Maximum AllWatcher frame size?

2017-06-14 Thread John Meinel
In 2.1 we did not chunk, in 2.2 we switch to gorilla/websocket which does support chunking into frames. I don't think we do any internal "well that would be too much information so we wont send it all". John =:-> On Wed, Jun 14, 2017 at 7:11 PM, Cory Johns wrote: >

Maximum AllWatcher frame size?

2017-06-14 Thread Cory Johns
https://github.com/juju/python-libjuju/issues/136 raises the issue that, for large models, the initial AllWatcher response frame can be large enough that it overruns the default maximum frame size of the websocket library (1MB). We can increase this limit fairly easily, but I wanted to find out