Re: Github Reviews vs Reviewboard

-1 On 14 October 2016 at 02:47, Tim Penhey wrote: > -1, like Menno I was initially quite hopeful for the github reviews. > > My main concerns are around easily having a list to pull from, and being > able to see status, comments on a single dashboard. > > Tim > > On

Juju Networking - an overview and proposal

I have wanted to put the world to rights, at least in terms of Juju networking, for a while now. It was suggested that I stopped being grumpy and get my thoughts down, so I did. My aim was to write down what, in my opinion, we need to do in order to make Juju elegant on the inside and capable on

Re: Automatic commit squashing

. On 16 June 2016 at 09:54, James Tunnicliffe <james.tunnicli...@canonical.com> wrote: > I would love to be given small, isolated, well planned work to do, the > specification of which never changes. That isn't the world I live in, > which is why I would like our ideals to be g

Re: Automatic commit squashing

inues with many of the issues we're fighting today. > > On Thu, Jun 16, 2016 at 12:16 PM James Tunnicliffe > <james.tunnicli...@canonical.com> wrote: >> >> TLDR: Having guidelines rather than rules is good. Having a tool >> mindlessly squashing commits can throw a

Re: Automatic commit squashing

TLDR: Having guidelines rather than rules is good. Having a tool mindlessly squashing commits can throw away valuable information. I am a little confused as to why we need to squash stuff at all. Git history isn't flat so if you don't want to see every commit in a branch that has landed then you

Re: A cautionary tale - mgo asserts

Surely we want to remove any ordering from the txn logic if Mongo makes no guarantees about keeping ordering? Being explicitly unordered at both ends seems right. James On Thu, Jun 9, 2016 at 8:35 AM, roger peppe wrote: > On 9 June 2016 at 01:20, Menno Smits

Re: adding unit tests that take a long time

Go test compiles a binary for each package with tests in, then runs it. Go 1.7 helps with the compile step. For each binary, all tests are run sequentially unless you call https://golang.org/pkg/testing/#T.Parallel to indicate a test can be run in parallel with other tests flagged as such. For any

Re: I think master is leaking

https://bugs.launchpad.net/juju-core/+bug/1564511 The reboot tests are broken - they patch out the creation of containers when they expect to create them, but not when they don't. They patch out the watching of containers when they want to see them reboot, but not when they don't. AFAIK they

Re: Proposal: doc.go for each package

A good way of reading go docs is godoc -http=:6060 and pointing your browser at http://localhost:6060/pkg/github.com/juju/juju/ to read the docs - no grep required. James On Wed, Aug 26, 2015 at 6:17 PM, roger peppe roger.pe...@canonical.com wrote: +1. We should definitely have package

Re: ppc64le timeouts cursing things

On 17 July 2015 at 13:08, Dimiter Naydenov dimiter.nayde...@canonical.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17.07.2015 12:07, James Tunnicliffe wrote: /me opens can of worms Thanks for starting the discussion :) Having spent perhaps too long trying to parallelise

Re: ppc64le timeouts cursing things

/me opens can of worms Having spent perhaps too long trying to parallelise the running of the unit test suite over multiple machines using various bat guano crazy ideas, I know too much about this but haven't got an easy fix. I do know the right fix is to re-write the very long tests that we

Re: Blocking bugs process

On 14 July 2015 at 15:31, Ian Booth ian.bo...@canonical.com wrote: On 14/07/15 23:26, Aaron Bentley wrote: On 2015-07-13 07:43 PM, Ian Booth wrote: By the definition given If a bug must be fixed for the next minor release, it is considered a ‘blocker’ and will prevent all landing on that

Re: please check your spam folders

Lots of CI emails end up in spam for me unless I specifically tell gmail not to. You can do this by creating a filter and ticking the never send to spam box, so for internal lists you could trust them. People in your contacts are trusted more than those who aren't for spam filtering purposes, but