Re: (not) using loggo in github.com/juju/errgo

2014-05-20 Thread Nate Finch
Actually, I just looked at the code again, and the code that uses loggo will be compiled out unless you modify the code to change a constant. Let's just remove the code and the package include, and if people want to modify the code to print out debugging info, they can do that however they want.

Re: (not) using loggo in github.com/juju/errgo

2014-05-20 Thread John Meinel
I'm fine having our split out packages depend on each other where it is actually useful (errors clearly depends on errgo), but it does sound like loggo isn't a very strong dependency and can just be removed. John =:- On Tue, May 20, 2014 at 3:27 PM, Nate Finch nate.fi...@canonical.comwrote:

Re: (not) using loggo in github.com/juju/errgo

2014-05-20 Thread David Cheney
SGTM. https://github.com/juju/errgo/pull/6 On Tue, May 20, 2014 at 10:06 PM, John Meinel j...@arbash-meinel.com wrote: I'm fine having our split out packages depend on each other where it is actually useful (errors clearly depends on errgo), but it does sound like loggo isn't a very strong

Re: (not) using loggo in github.com/juju/errgo

2014-05-20 Thread David Cheney
This has been done. github.com/juju/errgo no longer has a dependency on github.com/juju/loggo On Wed, May 21, 2014 at 7:39 AM, David Cheney david.che...@canonical.com wrote: SGTM. https://github.com/juju/errgo/pull/6 On Tue, May 20, 2014 at 10:06 PM, John Meinel j...@arbash-meinel.com wrote: