-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 2013-10-29 18:58, Andrew Deane wrote:
>
> I try never to avoid important features because they might be
> scary.
>
>
> Oh, I am saying use it, but just test it (like you said with the
> race detector enabled) and know the profile, before rolling
> I try never to avoid important features because they might be scary.
>
Oh, I am saying use it, but just test it (like you said with the race
detector enabled) and know the profile, before rolling it out.
>
> Also, just for the record, buffered channels will block just like
> unbuffered channel
I think this is a good idea. yes, we'll need some testing to make sure we
don't have races and deadlocks, but Go has a race detector and panics
nicely on deadlocks. Certainly, enabling multiprocessing on the one machine
that is most likely to be a bottleneck to a large system is a worthwhile
goal.
>From my experience we will need to pay attention to the logical flow of the
application. Its not a simple case of enabling all CPUs. We will need to
run many tests repeatedly to ensure there are no races or potential
deadlocks. Unbuffered channels are a particular cause of deadlock.
That said, en
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
My patch uses "runtime.GOMAXPROCS(runtime.NumCPU())" which means it
sets GOMAXPROCS=1 for machines that have 1 core.
I don't quite see what the problem is with this particular patch.
(taking advantage of multiple cores when they are available).
John
Not lgtm. The number of CPU cores available on the default ec2
bootstrap machine is 1.
On Tue, Oct 29, 2013 at 5:07 PM, John Arbash Meinel
wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Do we want to enable multiprocessing for Jujud? I have some evidence
> that it would actually hel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Do we want to enable multiprocessing for Jujud? I have some evidence
that it would actually help things.
I'm soliciting feedback about this patch:
=== modified file 'cmd/jujud/main.go'
- --- cmd/jujud/main.go 2013-09-13 14:48:13 +
+++ cmd/jujud/ma
