Re: Ensuring tests pass on gccgo

2014-05-22 Thread John Meinel
Please don't actually slow down the time it takes to land code to trunk by actually running the tests 2x in a row (and IME gccgo test suite is actually more than 1x the time for the golang test suite to run). I suppose if you can put them in parallel, but I'd really like to see it just be a CI

Re: Ensuring tests pass on gccgo

2014-05-22 Thread Gustavo Niemeyer
On Wed, May 21, 2014 at 10:43 PM, Ian Booth ian.bo...@canonical.com wrote: We are working to make all juju-core unit tests pass using gccgo. In case you didn't already know, there's a common issue which has caused a lot of the failures to date. Here's a quick heads up on how to deal with it.

Re: Ensuring tests pass on gccgo

2014-05-22 Thread Nate Finch
Although using DeepEquals on sorted lists does make for easier-to-understand test failure messages, the burden on the developer to sort the slices when they write the test doesn't seem worth it to me. We write tests a lot more often than we need to debug failing tests. If it was just slices of

Ensuring tests pass on gccgo

2014-05-21 Thread Ian Booth
Hi folks We are working to make all juju-core unit tests pass using gccgo. In case you didn't already know, there's a common issue which has caused a lot of the failures to date. Here's a quick heads up on how to deal with it. golang-go and gcc-go have different map implementations which results