Re: Proposed addition to code review guidelines

2016-07-25 Thread Menno Smits
+1. This seems like an obvious addition to the checklist. On 20 July 2016 at 14:26, Tim Penhey wrote: > Hi folks, > > With model migration entering the world as a first class citizen, we need > to ensure that all fields and documents added to state have appropriate >

Proposed addition to code review guidelines

2016-07-19 Thread Tim Penhey
Hi folks, With model migration entering the world as a first class citizen, we need to ensure that all fields and documents added to state have appropriate migrations done for them. In particular when adding a field it is likely that the state/migrations_internal_test.go will have a failing