Re: The Pros and Cons of ReviewBoard.

2014-09-22 Thread Matthew Williams
Just in case we're counting, another pro: You are able to seperate pushing branches to github and creating a new version of code for review Matty On Fri, Sep 19, 2014 at 4:37 PM, Eric Snow eric.s...@canonical.com wrote: Given that I've in some part driven the switch to ReviewBoard, I want to

The Pros and Cons of ReviewBoard.

2014-09-19 Thread Eric Snow
Given that I've in some part driven the switch to ReviewBoard, I want to make sure we are all on the same page and any decision on its future can be made objectively. This is an outgrowth of the current discussion on whether or not we should ditch reviewboard. Let's look at the pros and cons of

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Eric Snow
On Fri, Sep 19, 2014 at 9:37 AM, Eric Snow eric.s...@canonical.com wrote: Given that I've in some part driven the switch to ReviewBoard, I want to make sure we are all on the same page and any decision on its future can be made objectively. This is an outgrowth of the current discussion on

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Jonathan Aquilina
I am more than willing to help out wity those modifications Sent from Samsung Mobile Original message From: Eric Snow eric.s...@canonical.com Date: 19/09/2014 5:41 PM (GMT+01:00) To: juju-dev@lists.ubuntu.com Subject: Re: The Pros and Cons of ReviewBoard. On Fri, Sep

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Matthew Williams
At the risk of opening a can of worms: Reviewboard doesn't have to be a barrier to contributing. We could allow new contributors/ drive by fixes to use github. Matty On 19 Sep 2014 17:05, Eric Snow eric.s...@canonical.com wrote: On Fri, Sep 19, 2014 at 9:48 AM, Jonathan Aquilina

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Nate Finch
If we automate the creation of reviewboard reviews whenever a pull request is made, it would make it trivial even for outsiders. On Sep 19, 2014 5:01 PM, Matthew Williams matthew.willi...@canonical.com wrote: At the risk of opening a can of worms: Reviewboard doesn't have to be a barrier to

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Jonathan Aquilina
Thats what im suggesting be it coding somethign from scratch or adapting RB to make it much easier to work with. --- Regards, Jonathan Aquilina Founder Eagle Eye T On 2014-09-19 23:01, Matthew Williams wrote: At the risk of opening a can of worms: Reviewboard doesn't have to be a

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Jonathan Aquilina
I also suggested in another part of the thread sending an email when a new request is submitted to all those invovled with the reviewing. --- Regards, Jonathan Aquilina Founder Eagle Eye T On 2014-09-19 23:14, Nate Finch wrote: If we automate the creation of reviewboard reviews whenever a