Re: Use case for: min-version

2015-08-12 Thread Stuart Bishop
On 12 August 2015 at 05:02, Jeff Pihach jeff.pih...@canonical.com wrote: Version checking for features can be dangerous because a commands output or availability may change in the future and now your charm also needs a max-version, or version-range etc. A more robust solution could be

Re: Use case for: min-version

2015-08-12 Thread Stuart Bishop
On 12 August 2015 at 03:56, Tim Penhey tim.pen...@canonical.com wrote: It would be trivial for the Juju version to be exported in the hook context as environment variables. Perhaps something like this: JUJU_VERSION=1.24.4 JUJU_VERSION_MAJOR=1 JUJU_VERSION_MINOR=24 JUJU_VERSION_PATCH=4 #

Re: Use case for: min-version

2015-08-11 Thread Stuart Bishop
On 11 August 2015 at 03:32, Matt Bruzek matthew.bru...@canonical.com wrote: We wrote a charm that needed election logic, so we used the new Juju feature is_leader. A user was interested in using a bundle that contained this charm and it failed on them. It was hard to track down the cause of

Re: Use case for: min-version

2015-08-11 Thread Jeff Pihach
Version checking for features can be dangerous because a commands output or availability may change in the future and now your charm also needs a max-version, or version-range etc. A more robust solution could be something along the lines of a feature-supported query which would return whether