John
Thank you for discovering and working on this!
This sounds like an awful can of worms and should be addressed in a
dedicated manner.
I'll add it to the tech debt board and bug squad board with a reference
to your branch.
I am not sure that anyone on core has a capacity to tackle it right t
On 17 March 2016 at 09:43, John Meinel wrote:
> tl; dr: I need some help fixing our tests that are incorrectly not isolated
> from the real world.
>
> So...
>
> In investigating the bug with PatchValue and non pointer receivers, we
> realized that PatchValue calls AddCleanup. Which means that If y
tl; dr: I need some help fixing our tests that are incorrectly not isolated
from the real world.
So...
In investigating the bug with PatchValue and non pointer receivers, we
realized that PatchValue calls AddCleanup. Which means that If you are
doing:
func ... SetUpSuite() {
s.PatchValue(&foo,
So I spent a bit more time, and managed to get all of the tests to pass
again for me. I did fix the LXC tests that weren't isolated from the
backing filesystem. (If you ran the LXC tests on BTRFS it would notice that
it can '--snapshot' rather than use AUFS that the suite was testing.)
I also found
