Re: apiserver/testing.FakeAuthoriser is not a good mock

2014-07-31 Thread William Reade
On Thu, Jul 31, 2014 at 7:30 AM, David Cheney david.che...@canonical.com wrote: Proposal: remove Authoriser.GetAuthEntity() and replace all calls with Authoriser.GetAuthTag(). I have a branch for this, it's 30 lines as there are only 3 places in the apiserver where we do this and they

Re: apiserver/testing.FakeAuthoriser is not a good mock

2014-07-31 Thread David Cheney
On Thu, Jul 31, 2014 at 5:12 PM, William Reade william.re...@canonical.com wrote: On Thu, Jul 31, 2014 at 7:30 AM, David Cheney david.che...@canonical.com wrote: Proposal: remove Authoriser.GetAuthEntity() and replace all calls with Authoriser.GetAuthTag(). I have a branch for this, it's 30

apiserver/testing.FakeAuthoriser is not a good mock

2014-07-30 Thread David Cheney
Hello, This message serves as background to a series of changes coming soon. The goal of this message, and the changes that follow, is to describe the problems that I see with the FakeAuthoriser and a describe in general terms the steps I propose to address those shortcomings. Background: The