Re: github code reviews

2014-03-10 Thread Richard Harding
On Mon, 10 Mar 2014, Jonathan Aquilina wrote: I have two suggestions that might help, but first let me tell you a bit about myself. I am project manager for LMMS (Linux Multimedia Studio) and we recently started using github for our version control hosting. With this we started using

github code reviews

2014-03-07 Thread Nate Finch
I like github. I don't like in-line diffs and one email per code review comment, which is all github provides. So I did a quick google, and this came up: https://review.gerrithub.io/#/c/2160/2/roles/packstack/rdo/tasks/main.yml it looks pretty good. http://gerrithub.io/ -- Juju-dev mailing

Re: github code reviews

2014-03-07 Thread Matt Bruzek
Hi Nate, We used ReviewBoard at my last area and all the developers really liked the tool. It was very easy to review, and comment on code. ReviewBoard ( www.reviewboard.org ) allows in-line comments and according to the web page works with Bazaar and Git. I found the interface very clean and

Re: github code reviews

2014-03-07 Thread Richard Harding
On Fri, 07 Mar 2014, Nate Finch wrote: I like github. I don't like in-line diffs and one email per code review comment, which is all github provides. So I did a quick google, and this came up: https://review.gerrithub.io/#/c/2160/2/roles/packstack/rdo/tasks/main.yml it looks pretty