Re: removing colours from loggo package

2017-02-21 Thread Tim Penhey
Tech board says "yes let's do it", I'll respond to PR. On 22/02/17 14:15, Andrew Wilkins wrote: On Tue, Feb 21, 2017 at 10:02 PM roger peppe > wrote: In August, the loggo package was changed to make it log ANSI-terminal

Re: removing colours from loggo package

2017-02-21 Thread Andrew Wilkins
On Tue, Feb 21, 2017 at 10:02 PM roger peppe wrote: > In August, the loggo package was changed to make it log ANSI-terminal > colour escape sequences by default. > > I'm not sure that was the right decision, for a couple of reasons: > > - daemons are often given a

Re: removing colours from loggo package

2017-02-21 Thread roger peppe
I've proposed an initial PR to address this: https://github.com/juju/loggo/pull/25 On 21 February 2017 at 14:02, roger peppe wrote: > In August, the loggo package was changed to make it log ANSI-terminal > colour escape sequences by default. > > I'm not sure that was

removing colours from loggo package

2017-02-21 Thread roger peppe
In August, the loggo package was changed to make it log ANSI-terminal colour escape sequences by default. I'm not sure that was the right decision, for a couple of reasons: - daemons are often given a pseudo tty to run in, so the log files produced by our running services are now obscured by