New juju-core test suite

2014-05-20 Thread Ian Booth
Hi all A new test suite has been added - juju-core/testing/BaseSuite This new suite takes the place of LoggingSuite and provides the following features: - embeds LoggingSuite - disallows outgoing network access - clears env variables: HOME, JUJU_HOME, JUJU_ENV The code has been updated to use

Re: (not) using loggo in github.com/juju/errgo

2014-05-20 Thread Nate Finch
Actually, I just looked at the code again, and the code that uses loggo will be compiled out unless you modify the code to change a constant. Let's just remove the code and the package include, and if people want to modify the code to print out debugging info, they can do that however they want.

Re: (not) using loggo in github.com/juju/errgo

2014-05-20 Thread John Meinel
I'm fine having our split out packages depend on each other where it is actually useful (errors clearly depends on errgo), but it does sound like loggo isn't a very strong dependency and can just be removed. John =:- On Tue, May 20, 2014 at 3:27 PM, Nate Finch nate.fi...@canonical.comwrote:

Re: store migration

2014-05-20 Thread David Cheney
On Tue, May 20, 2014 at 11:55 PM, Francesco Banconi francesco.banc...@canonical.com wrote: Hi all, FYI this morning the UI team discussed about possibile paths to migrate the store code from lp:juju-core to Github. We are sharing this plan so that we can synchronize/collaborate with other

store migration

2014-05-20 Thread Francesco Banconi
Hi all, FYI this morning the UI team discussed about possibile paths to migrate the store code from lp:juju-core to Github. We are sharing this plan so that we can synchronize/collaborate with other teams with similar needs in their todo list. Here are the store package dependencies as

Re: store migration

2014-05-20 Thread Richard Harding
On Tue, 20 May 2014, David Cheney wrote: A possible plan is as follow: 1) Migrate juju-core/thirdparty to juju/thirdparty (Github). Since there are no dependencies here, this seems to be a good first candidate. nac, these are out horrors. The code we forked should either be pushed

Re: (not) using loggo in github.com/juju/errgo

2014-05-20 Thread David Cheney
SGTM. https://github.com/juju/errgo/pull/6 On Tue, May 20, 2014 at 10:06 PM, John Meinel j...@arbash-meinel.com wrote: I'm fine having our split out packages depend on each other where it is actually useful (errors clearly depends on errgo), but it does sound like loggo isn't a very strong

Re: Schema migration process

2014-05-20 Thread Menno Smits
On 19 May 2014 16:35, Tim Penhey tim.pen...@canonical.com wrote: On 16/05/14 17:29, John Meinel wrote: So I'm pretty sure the ability to do schema upgrades was scoped in the HA work that Nate is working on. I believe the idea is roughly: OK, I see the card on the board on Nate's team for

Re: store migration

2014-05-20 Thread Ian Booth
Hi We are looking to migrate juju-core across to github Real Soon Now™. The timeframe is hopefully by the end of next week, but depends on how soon we can get documentation finished, everything tested, and agreement to move ahead. It will be the entire juju-core codebase, and from there we plan

Re: store migration

2014-05-20 Thread David Cheney
With regard to the thirdparty package in core, I don't see that we need it any more. The only thing in it is pbkdf2, which is available from go.crypto which we import from anyway for ssh authorised keys functionality. So I say we nuke it. I'm going to fix this right now. -- Juju-dev

Re: (not) using loggo in github.com/juju/errgo

2014-05-20 Thread David Cheney
This has been done. github.com/juju/errgo no longer has a dependency on github.com/juju/loggo On Wed, May 21, 2014 at 7:39 AM, David Cheney david.che...@canonical.com wrote: SGTM. https://github.com/juju/errgo/pull/6 On Tue, May 20, 2014 at 10:06 PM, John Meinel j...@arbash-meinel.com wrote: