Re: Trivial bugs hurting progress

2015-03-04 Thread Curtis Hovey-Canonical
On Wed, Mar 4, 2015 at 8:44 AM, Martin Packman martin.pack...@canonical.com wrote: On 04/03/2015, Andrew Wilkins andrew.wilk...@canonical.com wrote: Curtis and I have talked about also doing a ppc64 test run as part of the gating job, that gets us the map ordering stuff as a newer go would,

Joyent SSH key

2015-03-04 Thread Nate Finch
There is a bug about us defaulting to uploading the user's private id_rsa ssh key to joyent as a part of bootstrapping a new server. This is obviously a bad thing. bug: https://bugs.launchpad.net/juju-core/+bug/1415671 However, the proposed solution (generate our own key and use that) doesn't

Re: Joyent SSH key

2015-03-04 Thread Nick Veitch
On 4 March 2015 at 17:23, Eric Snow eric.s...@canonical.com wrote: On Wed, Mar 4, 2015 at 10:04 AM, Nate Finch nate.fi...@canonical.com wrote: My suggested solution is that we do what we do for all the rest of the providers, which is to make the user give us authentication credentials in the

Re: Trivial bugs hurting progress

2015-03-04 Thread Tim Penhey
On 04/03/15 19:05, Andrew Wilkins wrote: The bugs were fixed in this branch: https://github.com/juju/juju/pull/1738 - invalid printf-style formatting will cause go vet to fail My bad. I had deleted the pre-push hook script some time ago when go vet failed continuously, and I hadn't reinstated

Re: Joyent SSH key

2015-03-04 Thread Andrew Wilkins
On Thu, Mar 5, 2015 at 1:04 AM, Nate Finch nate.fi...@canonical.com wrote: There is a bug about us defaulting to uploading the user's private id_rsa ssh key to joyent as a part of bootstrapping a new server. This is obviously a bad thing. bug:

Re: Trivial bugs hurting progress

2015-03-04 Thread Andrew Wilkins
On Thu, Mar 5, 2015 at 10:24 AM, Tim Penhey tim.pen...@canonical.com wrote: On 04/03/15 19:05, Andrew Wilkins wrote: The bugs were fixed in this branch: https://github.com/juju/juju/pull/1738 - invalid printf-style formatting will cause go vet to fail My bad. I had deleted the pre-push

Re: Trivial bugs hurting progress

2015-03-04 Thread John Meinel
One option is to run the test suite with go 1.3 and just make sure that juju compiles with all the other compilers (1.2, gccgo, etc). That gives us a fast precommit check, which won't catch everything, but should catch most 1.2 compat bugs. And leave the full test suite runs as CI tests. John =:-

Re: Trivial bugs hurting progress

2015-03-04 Thread Aaron Bentley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2015-03-04 08:53 AM, Dimiter Naydenov wrote: If it's about catching map ordering issues, let's use go 1.3+ as an extra step, rather than gccgo, which is buggy and slow and randomly segfaults. It's likely we'll slow down merge gating

Re: Trivial bugs hurting progress

2015-03-04 Thread Curtis Hovey-Canonical
On Wed, Mar 4, 2015 at 1:05 AM, Andrew Wilkins andrew.wilk...@canonical.com wrote: The bot is currently running (I think) Go 1.2. I'm running 1.4, Ian's running 1.3, and I'm sure Dave's running tip ;) Go 1.3+ made map iteration less deterministic, so these sorts of bugs are much more likely to

Re: Trivial bugs hurting progress

2015-03-04 Thread Martin Packman
On 04/03/2015, Andrew Wilkins andrew.wilk...@canonical.com wrote: Hi all, Ian asked me to mail the list about a couple of bugs that managed to get past the bot; first so that we can all be mindful of these sorts of bugs, and second to highlight the fact that they could have been caught by the

Re: Trivial bugs hurting progress

2015-03-04 Thread Dimiter Naydenov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 4.03.2015 15:44, Martin Packman wrote: On 04/03/2015, Andrew Wilkins andrew.wilk...@canonical.com wrote: Hi all, Ian asked me to mail the list about a couple of bugs that managed to get past the bot; first so that we can all be mindful of