Re: Upgrading minimum Go version?

Given how often people still use "--upload-tools" for things like private clouds (and is definitely the one used for local provider), I'd really worry about having a jujud on your local machine that wasn't built with the same toolchain as the one you get from "juju bootstrap" in other cases. Very

Re: Juju devel 1.26-alpha2 is available for testing

There are other options to play with juju+lxd on trusty... On Fri, Nov 27, 2015 at 2:26 PM, Rick Harding wrote: > > On Fri, Nov 27, 2015 at 11:35 AM Mark Shuttleworth wrote: >> >> On 27/11/15 16:21, Aaron Bentley wrote: >> >> It's dependent on what

Re: Upgrading minimum Go version?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2015-11-30 10:36 AM, John Meinel wrote: > Given how often people still use "--upload-tools" for things like > private clouds (and is definitely the one used for local provider), > I'd really worry about having a jujud on your local machine that

Re: Upgrading minimum Go version?

On Mon, Nov 30, 2015 at 10:36 AM, John Meinel wrote: > Given how often people still use "--upload-tools" for things like private > clouds (and is definitely the one used for local provider), I'd really worry > about having a jujud on your local machine that wasn't built

Re: Reviews for merges _from_ master to feature branches

On 01/12/15 13:56, Ian Booth wrote: > > > On 01/12/15 10:17, David Cheney wrote: >> Hello, >> >> Why are reviewers being created for merges from master to feature >> branches ? What purpose does this serve ? >> > > They appear because you create a github PR which triggers a reviewboard review >

Re: utils/fslock needs to DIAF

fcntl won't work in threaded go applications, it barely works in non threaded applications. I'm not interested in "doesn't work on windows" arguments. Yes, we have to support windows, but that doesn't mean we have to be dragged down to it's lowest common denominator. I think it's fine to develop

Re: utils/fslock needs to DIAF

On Tue, Dec 1, 2015 at 9:07 AM David Cheney wrote: > http://0pointer.de/blog/projects/locking.html > > In short, opening the same file twice and asserting a lock on it will > succeed. > Thanks. The article is a bit exasperated. Yes, there are problems to be aware of,

Re: utils/fslock needs to DIAF

Doesn't look like there is windows support, and it uses fcntl (flock) under the hood, which is what we have now. On Tue, Dec 1, 2015 at 10:55 AM, Casey Marshall wrote: > How about github.com/camlistore/lock ? > > On Mon, Nov 30, 2015 at 5:43 PM, Tim Penhey

Reviews for merges _from_ master to feature branches

Hello, Why are reviewers being created for merges from master to feature branches ? What purpose does this serve ? Thanks Dave -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: utils/fslock needs to DIAF

On Tue, Dec 1, 2015 at 10:43 AM, Tim Penhey wrote: > Hi folks, > > The fslock was a mistake that I added to the codebase some time back. It > provided an overly simplistic solution to a more complex problem. > > Really the filesystem shouldn't be used as a locking

Re: utils/fslock needs to DIAF

Please no. The better way is to use an abstract unix domain socket to create a mutex. On Tue, Dec 1, 2015 at 10:56 AM, Andrew Wilkins wrote: > On Tue, Dec 1, 2015 at 7:43 AM Tim Penhey wrote: >> >> Hi folks, >> >> The fslock was a mistake

Re: Reviews for merges _from_ master to feature branches

On Tue, Dec 1, 2015 at 8:18 AM David Cheney wrote: > Hello, > > Why are reviewers being created for merges from master to feature > branches ? What purpose does this serve ? > I just ignore them. If anyone's not sure if they resolved a conflict properly, they should

utils/fslock needs to DIAF

Hi folks, The fslock was a mistake that I added to the codebase some time back. It provided an overly simplistic solution to a more complex problem. Really the filesystem shouldn't be used as a locking mechanism. Most of the code that exists for the fslock now is working around its

Re: utils/fslock needs to DIAF

On Tue, Dec 1, 2015 at 7:43 AM Tim Penhey wrote: > Hi folks, > > The fslock was a mistake that I added to the codebase some time back. It > provided an overly simplistic solution to a more complex problem. > > Really the filesystem shouldn't be used as a locking

Re: Reviews for merges _from_ master to feature branches

It's not gonna get through the merge bot if that's the case. To clarify, using the landing bot, thumbs up, pointless reviews that nobody reviews and have poor descriptions, thumbs down. On Tue, Dec 1, 2015 at 11:20 AM, Rick Harding wrote: > Sanity check on merge

Re: Upgrading minimum Go version?

As of this morning, the unit tests pass on xenial (thanks to Andrew for getting them over the hump) using Go 1.5 On Tue, Dec 1, 2015 at 3:21 AM, Curtis Hovey-Canonical wrote: > On Mon, Nov 30, 2015 at 10:36 AM, John Meinel wrote: >> Given how often

Re: utils/fslock needs to DIAF

On Tue, Dec 1, 2015 at 7:57 AM David Cheney wrote: > Doesn't look like there is windows support, and it uses fcntl (flock) > under the hood, which is what we have now. > flock isn't the problematic thing Tim is talking about. utils/fslock attempts to create a

Re: utils/fslock needs to DIAF

How about github.com/camlistore/lock ? On Mon, Nov 30, 2015 at 5:43 PM, Tim Penhey wrote: > Hi folks, > > The fslock was a mistake that I added to the codebase some time back. It > provided an overly simplistic solution to a more complex problem. > > Really the

Re: utils/fslock needs to DIAF

On Tue, Dec 1, 2015 at 7:58 AM David Cheney wrote: > Please no. The better way is to use an abstract unix domain socket to > create a mutex. > I don't have a problem with that, but I'd like to know why it's better. > > On Tue, Dec 1, 2015 at 10:56 AM, Andrew

Re: utils/fslock needs to DIAF

On Tue, Dec 1, 2015 at 11:00 AM, Andrew Wilkins wrote: > On Tue, Dec 1, 2015 at 7:57 AM David Cheney > wrote: >> >> Doesn't look like there is windows support, and it uses fcntl (flock) >> under the hood, which is what we have now. > > >

Re: utils/fslock needs to DIAF

On Tue, Dec 1, 2015 at 8:03 AM David Cheney wrote: > On Tue, Dec 1, 2015 at 11:00 AM, Andrew Wilkins > wrote: > > On Tue, Dec 1, 2015 at 7:57 AM David Cheney > > wrote: > >> > >> Doesn't look like there is

Re: utils/fslock needs to DIAF

http://0pointer.de/blog/projects/locking.html In short, opening the same file twice and asserting a lock on it will succeed. On Tue, Dec 1, 2015 at 12:04 PM, Andrew Wilkins wrote: > On Tue, Dec 1, 2015 at 8:57 AM David Cheney > wrote:

Re: Upgrading minimum Go version?

Good discussion. I have one nuance that I think we want to discuss in SFO. Namely, controlling the Juju tool chain. Juju QA uses CI to make many of the things we releases, such as win agents. We use Launchpad/Ubuntu to make Ubuntu agents and clients. Juju QA qill soon have access to ARM hardware.