Re: juju/retry take 2 - looping

2016-10-20 Thread roger peppe
On 20 October 2016 at 16:30, Katherine Cox-Buday wrote: > John Meinel writes: > >> As commented on the pull request, passing 'err' into Next() initially feels >> weird, but >> it allows a big improvement to whether the loop exited

Re: juju/retry take 2 - looping

2016-10-20 Thread Katherine Cox-Buday
John Meinel writes: > As commented on the pull request, passing 'err' into Next() initially feels > weird, but > it allows a big improvement to whether the loop exited because we ran out of > retries, or it exited because the request succeeded. (loop.Error() > tells us

AWS US East (Ohio) Region now supported for Juju 2.x

2016-10-20 Thread Aaron Bentley
The Juju QA & Release team is pleased to announce support for Amazon's new US East (Ohio) Region, aka us-east-2. To use it with 2.0.0, just run "juju update-clouds" once. You will see the message: Updated your list of public clouds with 1 cloud region added: added cloud region: -

Re: juju/retry take 2 - looping

2016-10-20 Thread Ian Booth
I really like where the enhancements are headed. I feel they offer the syntax that some folks wanted, with the safety and validation of the initial implementation. Best of both worlds. On 20/10/16 13:09, Tim Penhey wrote: > Hi folks, > > https://github.com/juju/retry/pull/5/files > > As often

Re: juju/retry take 2 - looping

2016-10-20 Thread John Meinel
As commented on the pull request, passing 'err' into Next() initially feels weird, but it allows a big improvement to whether the loop exited because we ran out of retries, or it exited because the request succeeded. (loop.Error() tells us either way.) I wonder if we want to push harder on always