Re: End Of Review marker

+1 Rick. My opinion is it's just an issue of manners. After filling in comments inline let them know that you're done so they can start working on it. Likewise if you start doing a review and have some interruption and are unable to finish it let them know that there might be more to come. It's

Static Analysis on Juju

Hi Folks, As some of you will be aware the latest version of go includes some static analysis tools in godoc: http://golang.org/lib/godoc/analysis/help.html As is noted in the above, the analysis is quite slow (and resource intensive), but I wanted to find out if there was any useful output. To

Re: Thoughts to keep in mind for Code Review

I agree that the code needs to be self-explanatory enough to not require annotations, but annotations can be useful - especially for larger changes. Suggesting the order for code to be reviewed is certainly useful if you're reviewing code in a part of the system you aren't familiar with On Wed,

Re: Port ranges - restricting opening and closing ranges

26, 2014 at 2:11 PM, Domas Monkus domas.mon...@canonical.com wrote: Hi, me and Matthew Williams are working on support for port ranges in juju. There is one question that the networking model document does not answer explicitly and the simplicity (or complexity) of the implementation

Re: Reviewing - moving to review mentors, and guidelines

Is this still happening? M On 19 Jul 2014 09:43, Matthew Williams matthew.willi...@canonical.com wrote: +1 Great idea, thank you On 18 Jul 2014 03:28, Tim Penhey tim.pen...@canonical.com wrote: Hi all, Last night in the team meeting we discussed the review process. Initially because

Re: First customer pain point pull request - default-hook

Something to be mindful of is that we will shortly be implementing a new hook for metering (likely called collect-metrics). This hook differs slightly to the others in that it will be called periodically (e.g. once every hour) with the intention of sending metrics for that unit to the state

Re: First customer pain point pull request - default-hook

gust...@niemeyer.net wrote: On Tue, Aug 19, 2014 at 6:58 PM, Matthew Williams matthew.willi...@canonical.com wrote: Something to be mindful of is that we will shortly be implementing a new hook for metering (likely called collect-metrics). This hook differs slightly to the others

Re: gccgo internal compiler errors

As it's something we need to be doing for a while yet is there value in adding this as a task that gets run by the landing bot? Thanks Matty On Thu, Aug 28, 2014 at 11:48 PM, Tim Penhey tim.pen...@canonical.com wrote: Hi folks, I spent some time this morning looking at

Re: Lag for unblocking CI

Thanks Martin, yeah things have come up since it tried to land, I'll try again later today and let you know if there are any problems On Mon, Sep 1, 2014 at 2:49 PM, Martin Packman martin.pack...@canonical.com wrote: On 01/09/2014, John Meinel j...@arbash-meinel.com wrote: Is there some

auth fails bug reports

Hi Folks, Casey and I spent some time today looking at the auth fails during TearDownTest symptom/ bug: https://bugs.launchpad.net/juju-core/+bug/1348477. The failure seems to happen across various tests. The same problem was reported across a number of the errors listed in our juju test

Re: reviewboard

Thanks Eric, Taking it for a spin now, looks pretty cool Matty On Tue, Sep 9, 2014 at 3:47 PM, Eric Snow eric.s...@canonical.com wrote: On Mon, Sep 8, 2014 at 8:05 PM, Tim Penhey tim.pen...@canonical.com wrote: On 09/09/14 04:32, Eric Snow wrote: To install rbt: sudo pip install

Re: Doing chained diffs w/ Reviewboard

I've got it working. Using rbt it was pretty trivial. I'm not 100% sure of my steps - but from memory and some prompting from `history` the process was more or less: 1) rebase my branch against the latest version of the parent. Then: 2) rbt post -parent remotes/mattyw/my-parent-branch It

Re: The Pros and Cons of ReviewBoard.

At the risk of opening a can of worms: Reviewboard doesn't have to be a barrier to contributing. We could allow new contributors/ drive by fixes to use github. Matty On 19 Sep 2014 17:05, Eric Snow eric.s...@canonical.com wrote: On Fri, Sep 19, 2014 at 9:48 AM, Jonathan Aquilina

Re: The Pros and Cons of ReviewBoard.

Just in case we're counting, another pro: You are able to seperate pushing branches to github and creating a new version of code for review Matty On Fri, Sep 19, 2014 at 4:37 PM, Eric Snow eric.s...@canonical.com wrote: Given that I've in some part driven the switch to ReviewBoard, I want to

Re: Distributed systems theory

There's also the papers we love project https://github.com/papers-we-love/papers-we-love They have loads of papers about various topics. Here's the distributed systems section: https://github.com/papers-we-love/papers-we-love/tree/master/distributed_systems Matty On Tue, Sep 23, 2014 at 9:05

Re: Too space, or not two space

Believe it or not I also learned to type on a mechanical typewriter and I did double spaces on that. But you also needed to un jam it if you typed too fast. I'm voting for single space. -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at:

Where to Review

Hi Folks, I'm forgetful and disorganised at the best of times I can never remember where I should go to review a particular juju project. I *think* only juju/juju and juju/utils are in reviewboard and everything else is in github - but I can't remember - is that right? Do we have a definitive

Unit test failure in juju/errors

Hi Folks, It appears that juju/errors has a failing unit test: http://paste.ubuntu.com/10085832/ It also appears that it only fails in go1.4 Matty -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: gocheck in non test code

: I don't know if it is because of bad imports but I certainly see github.com/juju/juju/environs/testing github.com/juju/juju/juju/testing etc in the output of the go list output. John =:- On Tue, Apr 21, 2015 at 5:34 PM, Matthew Williams matthew.willi...@canonical.com wrote: Unless

Re: gocheck in non test code

those dependencies, but should only be imported in *_test.go code. John =:- On Tue, Apr 21, 2015 at 5:17 PM, Matthew Williams matthew.willi...@canonical.com wrote: Hi Folks, There seem to be a number of places in core where we end up importing gocheck in non test code. We should have

Public Service Annoucement

There's a very useful pre-push hook available for juju that does useful things like run gofmt, go vet, checks we can build etc. If you don't have it setup there's some lovely instructions in Contributing.md: https://github.com/juju/juju/blob/master/CONTRIBUTING.md#local-clone Thanks for

Re: Test suite on windows now voting on trunk

I wasn't able to work out why my test failed on windows, but I was able to realise that it wasn't really testing what I wanted. I'm landing a further change now that makes the tests a little better, and adds a new one, and I've confirmed that they pass in the right way on windows and ubuntu.

Re: Graduated reviewer: Domas Monkus

Congratulations Domas! On 23 Apr 2015 15:47, Casey Marshall casey.marsh...@canonical.com wrote: Juju developers, I would like to announce Domas Monkus is a fully graduated Juju core reviewer. This announcement is really long overdue.. Domas is careful and thoughtful in his reviews, his

Re: Fix for LP: #1174610 landing (unit ids should be unique)

This has now landed - and at the moment only in master so it will be out in 1.25 On Mon, Apr 27, 2015 at 5:44 PM, Casey Marshall casey.marsh...@canonical.com wrote: Just a friendly heads-up.. a fix for this longstanding bug will be landing into master shortly: LP: #1174610, unit ids should

Juju status & ubuntu snappy

Hey folks, I've been hacking around a bit more with juju and snappy. Thought you folks might be interested in seeing what I've come up with so far. Video: https://www.youtube.com/watch?v=JnbrWRDFqVo Blog post: http://blog.mattyw.net/blog/2015/10/18/snappy-juju-flasher-video/ Cheers Matty --

Re: Graduated Juju core reviewer: Aleš Stimec

Congratulations Ales. Good work On Wed, Oct 7, 2015 at 1:05 PM, Casey Marshall wrote: > All, > I'm pleased to announce Aleš Stimec is now a graduated Juju core reviewer. > His recent contributions and improvements to the Juju unit agent, > command-line

Problem Bootstrapping Azure

Hey Folks, Can someone with knowledge of azure respond to this issue? https://github.com/juju/juju/issues/3313 Many thanks Matty -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

On Call Reviewer Duties

Hey Folks, I propose that on call reviewers as part of their job should also review the issues list on https://github.com/juju/juju/issues and attempt to triage anything that's there. We moved to github to improve collaboration, but the issues list is often left ignored. If every OCR took a look

Re: mongo and ssh

Hi Neale, When you bootstrap, juju should be setting up mongo on the bootstrap server with all the correct settings and keys, you normally don't need to access the running mongodb, but if it's needed for debugging purposes it's possible. If you want to run mongo as part of your environment then

Re: Cleansing Mongo data

I seem to be missing something. Why do we need this? Matty On 24 Jun 2016 17:14, "Nate Finch" wrote: > It seems as though we should be cleansing all the keys since we never > know what queries we might want to make in the future. > > On Fri, Jun 24, 2016 at 12:04

Re: Awful dependency problem caused by romulus

Really sorry about this Dave, I'd not realised just how much they relied on each other. Surely there's an argument for romulus being merged into core? On Thu, May 19, 2016 at 8:55 AM, David Cheney wrote: > On Thu, May 19, 2016 at 5:04 PM, roger peppe

Re: Awful dependency problem caused by romulus

the best solution, I don't see how we can undo > the dependencies between cmd/juju and romulus -- they're so tightly > coupled they should probably live in the same repository. > > On Thu, May 19, 2016 at 6:45 PM, Matthew Williams > <matthew.willi...@canonical.com> wrote: > &g

Re: juju run-action --application?

it becomes more complex as to how > results are curated. Do you get back X UUIDs one for each unit or a single > action UUID but results returned in a different fashion? > > Marco > > On Wed, Aug 3, 2016, 12:35 PM Matthew Williams < > matthew.willi...@canonical.com> wrote: >

Leadership Election Tools

Hey Folks, Let's say I'm a charm author that wants to test leadership election in my charm. Are there any tools available that will let me force leadership election in juju so that I can test how my charm handles it? I was looking at the docs here:

Default Controller Type on GCE

Hello Juju Fans, I've recently been playing around with Juju on GCE. Google is suggesting that I could downgrade the instance type to save some money (attached screenshot) I was wondering if anyone else had something similar, and therefore, does this suggest our default controller instance type

One instance manual provider

Hey Folks, I notice the docs state that at least two instances are needed for the manual provider: https://jujucharms.com/docs/stable/clouds-manual. Some quick playing around suggests that this is indeed the case. Is there a technical reason why? I'd love to spin up a charm on [insert vps