Re: Squelching Leadership messages

2017-01-17 Thread Adam Collard
On Fri, 13 Jan 2017 at 15:51 Katherine Cox-Buday <
katherine.cox-bu...@canonical.com> wrote:

> John A Meinel  writes:
>
> > Note that we should still report leadership changes at INFO level, which
> should allow you to
> > debug easy things without changing the log level, as those changes
> should happen very
> > rarely.
>
> +1, thanks for this!
>

Hear hear, thanks John!

I'm looking forward to more signal in Juju logs \o/
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Re: Squelching Leadership messages

2017-01-13 Thread Katherine Cox-Buday
John A Meinel  writes:

> Note that we should still report leadership changes at INFO level, which 
> should allow you to
> debug easy things without changing the log level, as those changes should 
> happen very
> rarely.

+1, thanks for this!

-- 
Katherine

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Squelching Leadership messages

2017-01-13 Thread John A Meinel
I just proposed 2 branches, one for 2.1 and one for develop. So that the
"will renew leadership" message that triggers every 30s is dropped to DEBUG
level instead of INFO level. That should make those logs have a much higher
signal to noise ratio. But I want to make sure that if anyone is trying to
debug Leadership issues in their charms, they will likely want to use DEBUG
level.

Note that we should still report leadership changes at INFO level, which
should allow you to debug easy things without changing the log level, as
those changes should happen very rarely.

John
=:->

PRs>
 https://github.com/juju/juju/pull/6797
 https://github.com/juju/juju/pull/6798


This is what 'juju debug-log --include-module juju.worker.leadership' looks
like now:
unit-ul-3: 16:51:51 DEBUG juju.worker.leadership ul/3 making initial claim
for ul leadership
unit-ul-3: 16:51:51 INFO juju.worker.leadership ul leadership for ul/3
denied
unit-ul-3: 16:51:51 DEBUG juju.worker.leadership ul/3 waiting for ul
leadership release
unit-ul-3: 16:51:51 DEBUG juju.worker.leadership ul/3 is not ul leader
unit-ul-4: 16:52:01 DEBUG juju.worker.leadership ul/4 making initial claim
for ul leadership
unit-ul-4: 16:52:01 INFO juju.worker.leadership ul leadership for ul/4
denied
unit-ul-4: 16:52:01 DEBUG juju.worker.leadership ul/4 waiting for ul
leadership release
unit-ul-4: 16:52:01 DEBUG juju.worker.leadership ul/4 is not ul leader
unit-ul-4: 16:53:27 INFO juju.worker.leadership ul/4 promoted to leadership
of ul
unit-ul-3: 16:53:27 INFO juju.worker.leadership ul leadership for ul/3
denied
unit-ul-3: 16:53:27 DEBUG juju.worker.leadership ul/3 waiting for ul
leadership release
unit-ul-2: 16:53:40 DEBUG juju.worker.leadership ul/2 making initial claim
for ul leadership
unit-ul-2: 16:53:40 INFO juju.worker.leadership ul leadership for ul/2
denied
unit-ul-2: 16:53:40 DEBUG juju.worker.leadership ul/2 waiting for ul
leadership release
unit-ul-2: 16:53:41 DEBUG juju.worker.leadership ul/2 is not ul leader
unit-ul-3: 16:54:26 DEBUG juju.worker.leadership ul/3 making initial claim
for ul leadership
unit-ul-3: 16:54:26 INFO juju.worker.leadership ul leadership for ul/3
denied
unit-ul-3: 16:54:26 DEBUG juju.worker.leadership ul/3 waiting for ul
leadership release
unit-ul-3: 16:54:26 DEBUG juju.worker.leadership ul/3 is not ul leader
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev