Re: "juju attach"

2016-06-19 Thread Andrew Wilkins
On Sun, Jun 19, 2016 at 1:51 AM Mark Shuttleworth  wrote:

> On 18/06/16 16:45, Marco Ceppi wrote:
> >
> > Why not just "add" which is already pretty well used. Throughout the
> > Juju CLI.
> >
>
> Well, I think the context here is more attach-a-disk. I really like
> Roger's suggestion of 'mount', it immediately brings all the right
> elements into focus, and it's only one syllable.
>

I concur that add is not really appropriate here, and that mount makes a
lot of sense for storage (thanks for the suggestion, Roger). For me,
"attach" does not have similar connotations re resources, but at least
there's no looming danger of conflict with storage. I can't think of a
better single word, either.

We've got hooks called "storage-attached", and "storage-detaching", which
are in use by existing charms, and baked into charm helpers and probably
elsewhere. I don't think we can/should change these, or we'll have charms
that work with 2.0 but not 1.25, and vice versa. I think we should change
the statuses though, to keep the user-visible parts aligned.

Cheers,
Andrew


> Mark
>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Re: "juju attach"

2016-06-18 Thread Mark Shuttleworth
On 18/06/16 16:45, Marco Ceppi wrote:
>
> Why not just "add" which is already pretty well used. Throughout the
> Juju CLI.
>

Well, I think the context here is more attach-a-disk. I really like
Roger's suggestion of 'mount', it immediately brings all the right
elements into focus, and it's only one syllable.

Mark

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Re: "juju attach"

2016-06-18 Thread roger peppe
mount ?

On 18 June 2016 at 09:23, Mark Shuttleworth  wrote:
>
> We can change a CLI until RC, and its good for us to debate them.
>
> Here are the guiding principles.
>
>  * shorter is better, much much better
>  * we strongly prefer one word to always mean the same thing
>  * we strongly prefer a unique verb to a common-verb-plus-noun
>
> For the latter reason I prefer not to go to attach-storage, attach-nic
> and attach-cpu...  What you're looking for is a 1-3 syllable single verb
> which is distinct, nice to say, quick to tab-complete, and preferably
> implies storage.
>
> The one exception I can think  of is list-* where we like the
> tab-complete "tell me about all the things" experience.
>
> Suggestions welcome for the word, but these are the principles we'll
> decide by. I may add more principles later :)
>
> Mark
>
>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at: 
> https://lists.ubuntu.com/mailman/listinfo/juju-dev

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Re: "juju attach"

2016-06-18 Thread Mark Shuttleworth

We can change a CLI until RC, and its good for us to debate them.

Here are the guiding principles.

 * shorter is better, much much better
 * we strongly prefer one word to always mean the same thing
 * we strongly prefer a unique verb to a common-verb-plus-noun

For the latter reason I prefer not to go to attach-storage, attach-nic
and attach-cpu...  What you're looking for is a 1-3 syllable single verb
which is distinct, nice to say, quick to tab-complete, and preferably
implies storage.

The one exception I can think  of is list-* where we like the
tab-complete "tell me about all the things" experience.

Suggestions welcome for the word, but these are the principles we'll
decide by. I may add more principles later :)

Mark


-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


"juju attach"

2016-06-17 Thread Andrew Wilkins
Hi folks,

A couple of days ago I started looking at charming TitanDB. I was looking
at using resources to store the TitanDB distribution, and while looking at
the docs [0] I found a rather surprisingly named command: "juju attach".

The verb "attach" by itself tells me that, presumably, it will attach
something to something else. It doesn't tell me what. And because it's
non-specific, it either rules out the possibility of multiple unrelated
attach-type commands.

We always intended to give the user a means of attaching floating storage
to a unit/machine. i.e. I should be able to detach and reattach storage to
units in a model, so long as the storage provider supports it. I think the
commands would naturally be called "attach-storage" and "detach-storage".

Can we rename attach to attach-resource? Note that there's also "charm
attach". That may benefit from a similar rename too, at least to be
consistent.

Cheers,
Andrew

[0] https://jujucharms.com/docs/devel/developer-resources
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev