Re: Reviews for merges _from_ master to feature branches

2015-11-30 Thread Tim Penhey
On 01/12/15 13:56, Ian Booth wrote: > > > On 01/12/15 10:17, David Cheney wrote: >> Hello, >> >> Why are reviewers being created for merges from master to feature >> branches ? What purpose does this serve ? >> > > They appear because you create a github PR which triggers a reviewboard review >

Reviews for merges _from_ master to feature branches

2015-11-30 Thread David Cheney
Hello, Why are reviewers being created for merges from master to feature branches ? What purpose does this serve ? Thanks Dave -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: Reviews for merges _from_ master to feature branches

2015-11-30 Thread Andrew Wilkins
On Tue, Dec 1, 2015 at 8:18 AM David Cheney wrote: > Hello, > > Why are reviewers being created for merges from master to feature > branches ? What purpose does this serve ? > I just ignore them. If anyone's not sure if they resolved a conflict properly, they should

Re: Reviews for merges _from_ master to feature branches

2015-11-30 Thread David Cheney
It's not gonna get through the merge bot if that's the case. To clarify, using the landing bot, thumbs up, pointless reviews that nobody reviews and have poor descriptions, thumbs down. On Tue, Dec 1, 2015 at 11:20 AM, Rick Harding wrote: > Sanity check on merge