Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Ian Booth
On 23/05/17 06:39, Stuart Bishop wrote: > On 22 May 2017 at 20:02, roger peppe wrote: > >> not to show in the status history. Given that the motivation behind >> the proposal is to reduce load on the database and on controllers, I > > One of the motivations was to

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread roger peppe
Another optimisation possibility might be to send less status updates. For example, the uniter could wait until the hook has been executing for some period of time (e.g. 100ms) before sending the "executing" status. If the hook finishes within that period, it would send a bulk update with two

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread roger peppe
On 22 May 2017 at 09:55, Ian Booth wrote: > On 22/05/17 18:23, roger peppe wrote: >> I think it's slightly unfortunate that update-status exists at all - >> it doesn't really need to, >> AFAICS, as a charm can always do the polling itself if needed; for example: >> >>

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Alex Kavanagh
>From a 'principle of least surprise', I think that this proposal is probably a bad idea. The main driver is to (I guess) reduce the volume of 'chat' between the controller and 100's or 1000's of charms, and the effect this has on the status log. However, my 'guess' is also probably wrong as it

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Alex Kavanagh
>From a 'principle of least surprise', I think that this proposal is probably a bad idea. The main driver is to (I guess) reduce the volume of 'chat' between the controller and 100's or 1000's of charms, and the effect this has on the status log. However, my 'guess' is also probably wrong as it

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Stuart Bishop
On 22 May 2017 at 14:36, Tim Penhey wrote: > On 20/05/17 19:48, Merlijn Sebrechts wrote: >> >> On May 20, 2017 09:05, "John Meinel" > > wrote: >> >> I would actually prefer if it shows up in 'juju status' but

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Stuart Bishop
On 22 May 2017 at 14:36, Tim Penhey wrote: > On 20/05/17 19:48, Merlijn Sebrechts wrote: >> >> On May 20, 2017 09:05, "John Meinel" > > wrote: >> >> I would actually prefer if it shows up in 'juju status' but

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Ian Booth
On 22/05/17 18:23, roger peppe wrote: > I think it's slightly unfortunate that update-status exists at all - > it doesn't really need to, > AFAICS, as a charm can always do the polling itself if needed; for example: > > while :; do > sleep 30 > juju-run $UNIT 'status-set

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread roger peppe
I think it's slightly unfortunate that update-status exists at all - it doesn't really need to, AFAICS, as a charm can always do the polling itself if needed; for example: while :; do sleep 30 juju-run $UNIT 'status-set current-status "this is what is happening"' done &

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread roger peppe
I think it's slightly unfortunate that update-status exists at all - it doesn't really need to, AFAICS, as a charm can always do the polling itself if needed; for example: while :; do sleep 30 juju-run $UNIT 'status-set current-status "this is what is happening"' done &

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Tim Penhey
On 20/05/17 19:48, Merlijn Sebrechts wrote: On May 20, 2017 09:05, "John Meinel" > wrote: I would actually prefer if it shows up in 'juju status' but that we suppress it from 'juju status-log' by default. This is still very

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Tim Penhey
On 20/05/17 19:48, Merlijn Sebrechts wrote: On May 20, 2017 09:05, "John Meinel" > wrote: I would actually prefer if it shows up in 'juju status' but that we suppress it from 'juju status-log' by default. This is still very

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Tim Penhey
On 19/05/17 19:21, roger peppe wrote: On 19 May 2017 at 03:13, Tim Penhey wrote: Hi folks, Currently juju will update the status of any hook execution for any unit to show that it is busy doing things. This was all well and good until we do things based on time.

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-22 Thread Tim Penhey
On 19/05/17 19:21, roger peppe wrote: On 19 May 2017 at 03:13, Tim Penhey wrote: Hi folks, Currently juju will update the status of any hook execution for any unit to show that it is busy doing things. This was all well and good until we do things based on time.

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-20 Thread Merlijn Sebrechts
On May 20, 2017 09:05, "John Meinel" wrote: I would actually prefer if it shows up in 'juju status' but that we suppress it from 'juju status-log' by default. This is still very strange behavior. Why should this be default? Just pipe the output of juju status through

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-20 Thread Merlijn Sebrechts
Not showing subsequent runs seems very strange behavior as an end user and will complicate debugging issues with update-status hooks. Don't remove logs just because they are too verbose, there are use-cases where this info is needed. On May 19, 2017 04:14, "Tim Penhey"

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-20 Thread Merlijn Sebrechts
Not showing subsequent runs seems very strange behavior as an end user and will complicate debugging issues with update-status hooks. Don't remove logs just because they are too verbose, there are use-cases where this info is needed. On May 19, 2017 04:14, "Tim Penhey"

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-20 Thread John Meinel
I would actually prefer if it shows up in 'juju status' but that we suppress it from 'juju status-log' by default. (*possibly* we could show it with a flag, but I'm not sure that it is worth tracking or not.) John =:-> On Fri, May 19, 2017 at 9:42 PM, Gregory Lutostanski <

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-20 Thread John Meinel
I would actually prefer if it shows up in 'juju status' but that we suppress it from 'juju status-log' by default. (*possibly* we could show it with a flag, but I'm not sure that it is worth tracking or not.) John =:-> On Fri, May 19, 2017 at 9:42 PM, Gregory Lutostanski <

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread Gregory Lutostanski
What would happen if the update-status hook hangs here? I know it only is supposed to be for short-duration status messages (but charm bugs are known to happen). In addition, it will also block other hooks/actions from happening until completed and it will remain in a stuck state with the status

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread Gregory Lutostanski
What would happen if the update-status hook hangs here? I know it only is supposed to be for short-duration status messages (but charm bugs are known to happen). In addition, it will also block other hooks/actions from happening until completed and it will remain in a stuck state with the status

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread John Meinel
All agents start up in DEBUG until they can talk to the controller and read what the current logging config is set to. Otherwise you wouldn't be able to debug startup issues. That said, I think there was a request to cache the last-known value in agent.conf which would let restarts be less noisy.

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread John Meinel
All agents start up in DEBUG until they can talk to the controller and read what the current logging config is set to. Otherwise you wouldn't be able to debug startup issues. That said, I think there was a request to cache the last-known value in agent.conf which would let restarts be less noisy.

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread Uros Jovanovic
+1 On Fri, May 19, 2017 at 4:13 AM, Tim Penhey wrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit > to show that it is busy doing things. This was all well and good until we > do things based on time. > > Every five minutes

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread Uros Jovanovic
+1 On Fri, May 19, 2017 at 4:13 AM, Tim Penhey wrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit > to show that it is busy doing things. This was all well and good until we > do things based on time. > > Every five minutes

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread Adam Collard
On Fri, 19 May 2017 at 03:14 Tim Penhey wrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit > to show that it is busy doing things. This was all well and good until > we do things based on time. > > Every five minutes (or so)

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread roger peppe
On 19 May 2017 at 03:13, Tim Penhey wrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit to > show that it is busy doing things. This was all well and good until we do > things based on time. > > Every five minutes (or so) each

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread roger peppe
On 19 May 2017 at 03:13, Tim Penhey wrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit to > show that it is busy doing things. This was all well and good until we do > things based on time. > > Every five minutes (or so) each

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-19 Thread Ante Karamatić
+1 On Fri, May 19, 2017 at 6:10 AM David Britton wrote: > +1 from me: https://bugs.launchpad.net/juju/+bug/1530840 > > :) > > On Thu, May 18, 2017 at 8:13 PM, Tim Penhey > wrote: > >> Hi folks, >> >> Currently juju will update the status

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-18 Thread David Britton
+1 from me: https://bugs.launchpad.net/juju/+bug/1530840 :) On Thu, May 18, 2017 at 8:13 PM, Tim Penhey wrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit > to show that it is busy doing things. This was all well and good

Re: PROPOSAL: stop recording 'executing update-status hook'

2017-05-18 Thread David Britton
+1 from me: https://bugs.launchpad.net/juju/+bug/1530840 :) On Thu, May 18, 2017 at 8:13 PM, Tim Penhey wrote: > Hi folks, > > Currently juju will update the status of any hook execution for any unit > to show that it is busy doing things. This was all well and good