I'd also stick with the convention that ! means modification of one or more
of the arguments (typically first argument), and definitely not have it for
anything where there is some external state modification that is just an
implementation detail.
(if somethings purpose is to set global state, s
vote for "without !"
On Monday, September 28, 2015 at 6:40:36 PM UTC+2, Steven G. Johnson wrote:
>
>
>
> On Monday, September 28, 2015 at 12:34:01 PM UTC-4, Tom Breloff wrote:
>>
>> A question regarding the use of `!` came up a few days ago (
>> https://github.com/tbreloff/Plots.jl/issues/30#issue
So it seems like there's not an enthusiastic agreement, but that the
slightly better answer is `immerse()` rather than `immerse!()`? I suppose
I'll make some api changes to remove similar `!` instances, and the next
tag will be a minor version. Thanks.
On Mon, Sep 28, 2015 at 12:40 PM, Steven G
On Monday, September 28, 2015 at 12:34:01 PM UTC-4, Tom Breloff wrote:
>
> A question regarding the use of `!` came up a few days ago (
> https://github.com/tbreloff/Plots.jl/issues/30#issuecomment-142995667),
> and I wanted to quickly poll the users to get opinions.
>
> When a module maintains