Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-02-14 Thread Landon Blake
MM: I think you solution of attaching an undoable command to a layer is an elegant solution to the problem we discussed. I'm thinking it would be cool at some point to allow the user to set the start and end points of a group of undoable commands. That way we could remove one group of commands

Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-01-20 Thread edgar . soldin
On 19.01.2013 13:40, Michaël Michaud wrote: 3) The slowness of right click on a layername seems to be related to the windows clipboard, not the openjump undo stack. If you empty the clipboard (just select an empty string), openjump behaves normally again. I don't think it is necessary to go

Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-01-20 Thread Michaël Michaud
Hi all, I just made two fixes which should solve the memory leaks observed by Jukka (r3247). *First is a one-line fix in AddNewFeaturesPlugIn* which retained the whole text added as WKT. Now EnterWKTDialog free the resources before returning. *Second is a much larger fix on undo/redo

Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-01-19 Thread Rahkonen Jukka
Hi, My data were just polygons from BBOXes. I believe you can make the first test by making 20 copies of one polygon with a text editor and copy-paste them all into WKT input box. POLYGON ((40 280, 40 320, 80 320, 80 280, 40 280)) -Jukka- Landon Blake wrote: Jukka: Can you send me

Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-01-19 Thread Michaël Michaud
Hi Jukka, I started analysing the problem and I think there are different things in your observations. 1) features kept in the undo stack. Yes, they are. I think this is the normal behaviour as you may want to undo the add wkt geometry action, but in this case, this takes a lot of memory. 2)

Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-01-19 Thread Rahkonen Jukka
Hi, Thanks for analyzing this. The biggest problem for me was 3) the slowness. So it is not OJ bug but it is also impossible to guess that Windows clipboard should be cleared. Perhaps I will edit the string ui.plugin.AddNewFeaturesPlugIn.enter-well-known-text-for-one-or-more-geometries and

Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-01-19 Thread Michaël Michaud
Hi, Thanks for analyzing this. The biggest problem for me was 3) the slowness. So it is not OJ bug but it is also impossible to guess that Windows clipboard should be cleared. Perhaps I will edit the string ui.plugin.AddNewFeaturesPlugIn.enter-well-known-text-for-one-or-more-geometries Yes,

Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-01-19 Thread Landon Blake
Good observations MM. Does OJ currently have a way to clear the undo queue? If not, I might look into to adding that functionality next week. Landon On Sat, Jan 19, 2013 at 4:40 AM, Michaël Michaud michael.mich...@free.fr wrote: Hi Jukka, I started analysing the problem and I think there

Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-01-19 Thread Rahkonen Jukka
Michaël Michaud wrote: Do you know the new csv driver can already read files containing wkt geometries. May be an enhanced version (including BBOX) or a new driver (to parse log files) is really what you need ? No, I did not remember that csv driver reads WKT. You are right about the real

[JPP-Devel] Issues after adding loads of features as WKT

2013-01-18 Thread Rahkonen Jukka
Hi, While playing with BBOXes converted into polygons I noticed that OJ does not work extremely well after pasting for example 20 polygons as WKT from clipboard into the WKT input box. The conversion into OJ features is surprisingly fast, but after the polygons have been inserted into the

Re: [JPP-Devel] Issues after adding loads of features as WKT

2013-01-18 Thread Landon Blake
Jukka: Can you send me you data so I can do some testing. I remember this same issue being raised on the mailing list before, and I thought it had been corrected. Maybe not. At any rate, I'd like to do some poking around with the data you are using to see if I can verify a problem. Landon On