Re: [JPP-Devel] JUMP-Lib Improvements for OpenJUMP

2013-07-03 Thread Landon Blake
Michael: You wrote: Can you explain what Feature#clone(int id) does ? Does it create a distinct instance with the same FID ? Is it safe to authorize that ? I probably wouldn't port this method directly to OJ. In JUMP-Lib you do a lot of cloning because features are immutable (that is part of

Re: [JPP-Devel] JUMP-Lib Improvements for OpenJUMP

2013-07-02 Thread edgar . soldin
sounds good to me, especially the 'not breaking' part. let's see what you commit, maybe we eventually get our builds unit checked if i find time to implement that. ..ede On 02.07.2013 03:57, Landon Blake wrote: Ede: Let me see if I can provide a little more information. I'm proposing

Re: [JPP-Devel] JUMP-Lib Improvements for OpenJUMP

2013-07-02 Thread Michaƫl Michaud
Hi Landon, +1 for adding unit tests, before adding a method into a core class, I would wonder if it is useful for OJ core or for a plugin though. If it is only useful for testing, maybe it should be added in the unit testing package. Can you explain what Feature#clone(int id) does ? Does it

Re: [JPP-Devel] JUMP-Lib Improvements for OpenJUMP

2013-06-27 Thread edgar . soldin
On 27.06.2013 05:15, Landon Blake wrote: I'd like to port some features from JUMP-Lib to OpenJUMP. These features are listed here: http://openjumpblog.wordpress.com/2013/06/27/improvements-from-jump-lib-for-openjump/ What do you guys think? I'm basically adding some standard utility

[JPP-Devel] JUMP-Lib Improvements for OpenJUMP

2013-06-26 Thread Landon Blake
I'd like to port some features from JUMP-Lib to OpenJUMP. These features are listed here: http://openjumpblog.wordpress.com/2013/06/27/improvements-from-jump-lib-for-openjump/ What do you guys think? I'm basically adding some standard utility methods to the Feature/BasicFeature and