[JPP-Devel] Compile OpenJUMP 1.9.1 into Eclipse

2016-03-24 Thread Juan Carlos Gutiérrez Villavicencio 
Greetings list,
Please, how do I configure Eclipse to compile OpenJUMP 1.9.1?

Saludos cordiales,

Juan Carlos Gutiérrez
Perú
--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

[JPP-Devel] SVN: [4861] core/trunk

2016-03-24 Thread jump-pilot-svn 
Revision: 4861
  http://sourceforge.net/p/jump-pilot/code/4861
Author:   michaudm
Date: 2016-03-24 20:04:26 + (Thu, 24 Mar 2016)
Log Message:
---
add build-helper-maven-plugin in maven to be able to run tests located in 
jumptest package

Modified Paths:
--
core/trunk/ChangeLog
core/trunk/pom.xml

Modified: core/trunk/ChangeLog
===
--- core/trunk/ChangeLog2016-03-23 21:30:03 UTC (rev 4860)
+++ core/trunk/ChangeLog2016-03-24 20:04:26 UTC (rev 4861)
@@ -3,7 +3,11 @@
 # 2. make sure that lines break at 80 chars for constricted display situations
 #< 80 chars 
-->#
 
-2016-03- 23 Giuseppe Aruta  
+2016-03-24 mmichaud 
+  * add build-helper-maven-plugin in maven to be able to run tests located
+in jumptest package
+
+2016-03-23 Giuseppe Aruta  
   * emhenced version of RasterImageLayerPropertiesPlugIn: 
   * 1) New info HTML table "a la" GvSIG style
   * 2) Faster info checker (all cell statistic related to Sextante raster 
image 

Modified: core/trunk/pom.xml
===
--- core/trunk/pom.xml  2016-03-23 21:30:03 UTC (rev 4860)
+++ core/trunk/pom.xml  2016-03-24 20:04:26 UTC (rev 4861)
@@ -662,6 +662,25 @@
 
 
+
+org.codehaus.mojo
+build-helper-maven-plugin
+1.9.1
+
+
+add-junit-test-source
+generate-test-sources
+
+add-test-source
+
+
+
+src/jumptest
+
+
+
+
+

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-24 Thread Michaël Michaud 

Hi,

>> Hi,
>>
>> I was not frightened at all,
> maybe you should be ;)
Yes of course I can introduce new bugs. The risk is quite low with the 
kind of changes I've done since 1.9.1, but I don't exclude to do deeper 
changes.
Hopefully, we have a good and stable 1.9.1 release, and it seems a good 
time for this kind of work.

>
>> just curious and also glad. Cleaning old code that is not really broken is 
>> something that usually remains undone.
> "never touch a running system"
I don't completely agree. If you just want to "use" the soft, you're 
right. If you want a living and evolving code base, I think that 
cleaning, refactoring is part of the process, it should not necessarily 
be driven by bug fixes.
>
>> Another example is developer "goatbar" who has been cleaning the codebase of 
>> GDAL with his +1400 changesets
>> https://trac.osgeo.org/gdal/search?q=goatbar=1=on
> not saying it shouldn't be done. just has to be done carefully and while 
> functionality does not increase it inherently has the danger of breaking 
> things.
I'll discuss on the list any change which may introduce a risk 
(according to my criteria).
>
>> I have also seen in the Geoserver project how much work it can require if 
>> there is a need to migrate over very many library versions like with Wicket 
>> 1.4 from 2009 -> Wicket 7.x 
>> https://wiki.osgeo.org/wiki/GeoServer_Code_Sprint_2016. Upgrading to 
>> Spring-4 is also a big task even it is not so much delayed 
>> https://github.com/geoserver/geoserver/wiki/Spring-4-Upgrade.
> yeah, but at least upgrading dependencies usually gives you more stable, 
> better libs you work w/ in the future.
>
> anyway.. i have full confidence in the french/czech teamup Mike ..ede
Thanks,
I also can undertake some changes with more confidence because I know I 
can get excellent support on this list either in GIS area or in java 
programming area ;-)

Michaël
>
>> -Jukka Rahkonen-
>>
>> edgar.soldin wrote:
>>
>>> as far as i have seen the changes were more of a formatting natures so far. 
>>> but, Jukka is right of course, touching existing working code is prone to 
>>> introduce errors.
>>> that being said, i trust you'll be extra careful and try not to introduce 
>>> new code if not absolutely needed.
>> ..ede
>>
>> rOn 24.03.2016 00:01, Michaël Michaud wrote:
>>> Hi Jukka,
>>>
>>> Some benefits are :
>>> - making the code more readable (with for each loop, generics,
>>> autoboxing : formatting and using simpler syntax help to understand
>>> the code more quickly)
>>> - making the code more safe (using generics, try with resource)
>>> - most of things I rewrite are suggestions from my IDE (it may detect 
>>> actual bugs, but more often
>>>"potential" bug or simply bad practises )
>>> - removing dead code (useless bytes to load) or duplicated code (error
>>> prone)
>>> - for me, it is also a good way to have a better knowledge of the codebase.
>>> ...
>>>
>>> Benefit is not very high for the short term (it is not supposed to change 
>>> the way OJ works).
>>> But I hope it will make the code more attractive. I think it may also
>>> be a first step for bigger refactoring task if needed.
>>>
>>> Michaël
>>>
>>> Le 23/03/2016 22:49, Rahkonen Jukka (MML) a écrit :
 Hi,

   

 Michaël seems to do much work with "Cleaning, formatting rewriting". As a 
 non-programmer I would like to know what and why, and what benefit 
 OpenJUMP will have from this code review.

   

 Regards,

   

 -Jukka Rahkonen-



 -
 -
 Transform Data into Opportunity.
 Accelerate data analysis in your applications with Intel Data
 Analytics Acceleration Library.
 Click to learn more.
 http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140


 ___
 Jump-pilot-devel mailing list
 Jump-pilot-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>
>>>
>>> --
>>> 
>>> Transform Data into Opportunity.
>>> Accelerate data analysis in your applications with Intel Data
>>> Analytics Acceleration Library.
>>> Click to learn more.
>>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
>>>
>>>
>>>
>>> ___
>>> Jump-pilot-devel mailing list
>>> Jump-pilot-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>
>> --
>> Transform Data into Opportunity.
>> Accelerate data analysis in your applications with Intel Data Analytics 
>> Acceleration Library.
>> Click to learn more.
>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
>> ___
>>

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-24 Thread edgar . soldin 
On 24.03.2016 11:38, Rahkonen Jukka (MML) wrote:
> Hi,
> 
> I was not frightened at all, 

maybe you should be ;)

>just curious and also glad. Cleaning old code that is not really broken is 
>something that usually remains undone.  

"never touch a running system"

>Another example is developer "goatbar" who has been cleaning the codebase of 
>GDAL with his +1400 changesets
> https://trac.osgeo.org/gdal/search?q=goatbar=1=on

not saying it shouldn't be done. just has to be done carefully and while 
functionality does not increase it inherently has the danger of breaking things.

> I have also seen in the Geoserver project how much work it can require if 
> there is a need to migrate over very many library versions like with Wicket 
> 1.4 from 2009 -> Wicket 7.x 
> https://wiki.osgeo.org/wiki/GeoServer_Code_Sprint_2016. Upgrading to Spring-4 
> is also a big task even it is not so much delayed 
> https://github.com/geoserver/geoserver/wiki/Spring-4-Upgrade.

yeah, but at least upgrading dependencies usually gives you more stable, better 
libs you work w/ in the future.

anyway.. i have full confidence in the french/czech teamup Mike ..ede

> 
> -Jukka Rahkonen- 
> 
> edgar.soldin wrote:
> 
>> as far as i have seen the changes were more of a formatting natures so far. 
>> but, Jukka is right of course, touching existing working code is prone to 
>> introduce errors.
> 
>> that being said, i trust you'll be extra careful and try not to introduce 
>> new code if not absolutely needed.
> 
> ..ede
> 
> rOn 24.03.2016 00:01, Michaël Michaud wrote:
>> Hi Jukka,
>>
>> Some benefits are :
>> - making the code more readable (with for each loop, generics, 
>> autoboxing : formatting and using simpler syntax help to understand 
>> the code more quickly)
>> - making the code more safe (using generics, try with resource)
>> - most of things I rewrite are suggestions from my IDE (it may detect actual 
>> bugs, but more often
>>   "potential" bug or simply bad practises )
>> - removing dead code (useless bytes to load) or duplicated code (error 
>> prone)
>> - for me, it is also a good way to have a better knowledge of the codebase.
>> ...
>>
>> Benefit is not very high for the short term (it is not supposed to change 
>> the way OJ works).
>> But I hope it will make the code more attractive. I think it may also 
>> be a first step for bigger refactoring task if needed.
>>
>> Michaël
>>
>> Le 23/03/2016 22:49, Rahkonen Jukka (MML) a écrit :
>>>
>>> Hi,
>>>
>>>  
>>>
>>> Michaël seems to do much work with "Cleaning, formatting rewriting". As a 
>>> non-programmer I would like to know what and why, and what benefit OpenJUMP 
>>> will have from this code review.
>>>
>>>  
>>>
>>> Regards,
>>>
>>>  
>>>
>>> -Jukka Rahkonen-
>>>
>>>
>>>
>>> -
>>> -
>>> Transform Data into Opportunity.
>>> Accelerate data analysis in your applications with Intel Data 
>>> Analytics Acceleration Library.
>>> Click to learn more.
>>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
>>>
>>>
>>> ___
>>> Jump-pilot-devel mailing list
>>> Jump-pilot-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>>
>>
>> --
>> 
>> Transform Data into Opportunity.
>> Accelerate data analysis in your applications with Intel Data 
>> Analytics Acceleration Library.
>> Click to learn more.
>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
>>
>>
>>
>> ___
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
> 
> --
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with Intel Data Analytics 
> Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> 
> --
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with
> Intel Data Analytics Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> 

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration

Re: [JPP-Devel] jumptests / taskmonitor

2016-03-24 Thread edgar . soldin 
On 24.03.2016 08:28, Michaël Michaud wrote:
> Hi Ede,
> 
> I can start tests (jumptests) from my IDE, but not from maven test task. 
> Any idea ?

maybe because our test/ folder is named jumptest/ ?
 
http://stackoverflow.com/questions/6178583/maven-does-not-find-junit-tests-to-run

> In the jump/task package, we can see two layers
> - original TaskMonitor
> - TaskMonitorV2, used by WFS Plugin and adding a title attribute to 
> TaskMonitor
> A helper class related to V2 (TaskMonitorUtil) has also been added but 
> is unused,
> and WFS plugin contains code like if TaskMonitor instanceof 
> TaskMonitorV2) ...
> 
> I would be encline to add setTitle method in TaskMonitor interface in 
> order to
> simplify the whole API. Any objection ?
> 

the reason for this whole jumping through hoops is that taskmonitor is merily 
an interface. so in theory, any package out there might create an own class 
implementing the interface and use it.
if we just add to the interface, the extension having an own taskmonitor will 
break.

how about replacing, the instanceof code with the TaskMonitorUtil method for 
code reusage (probably wanted to do that anyway) and leave it like that?

..ede

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] Cleaning, formatting rewriting

2016-03-24 Thread edgar . soldin 
as far as i have seen the changes were more of a formatting natures so far. 
but, Jukka is right of course, touching existing working code is prone to 
introduce errors.

that being said, i trust you'll be extra careful and try not to introduce new 
code if not absolutely needed.

..ede

rOn 24.03.2016 00:01, Michaël Michaud wrote:
> Hi Jukka,
> 
> Some benefits are :
> - making the code more readable (with for each loop, generics, autoboxing : 
> formatting and using simpler syntax help to understand the code more quickly)
> - making the code more safe (using generics, try with resource)
> - most of things I rewrite are suggestions from my IDE (it may detect actual 
> bugs, but more often
>   "potential" bug or simply bad practises )
> - removing dead code (useless bytes to load) or duplicated code (error prone)
> - for me, it is also a good way to have a better knowledge of the codebase.
> ...
> 
> Benefit is not very high for the short term (it is not supposed to change the 
> way OJ works).
> But I hope it will make the code more attractive. I think it may also be a 
> first step for bigger
> refactoring task if needed.
> 
> Michaël
> 
> Le 23/03/2016 22:49, Rahkonen Jukka (MML) a écrit :
>>
>> Hi,
>>
>>  
>>
>> Michaël seems to do much work with “Cleaning, formatting rewriting”. As a 
>> non-programmer I would like to know what and why, and what benefit OpenJUMP 
>> will have from this code review.
>>
>>  
>>
>> Regards,
>>
>>  
>>
>> -Jukka Rahkonen-
>>
>>
>>
>> --
>> Transform Data into Opportunity.
>> Accelerate data analysis in your applications with
>> Intel Data Analytics Acceleration Library.
>> Click to learn more.
>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
>>
>>
>> ___
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> 
> 
> 
> --
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with
> Intel Data Analytics Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
> 
> 
> 
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> 

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

[JPP-Devel] jumptests / taskmonitor

2016-03-24 Thread Michaël Michaud 
Hi Ede,

I can start tests (jumptests) from my IDE, but not from maven test task. 
Any idea ?

In the jump/task package, we can see two layers
- original TaskMonitor
- TaskMonitorV2, used by WFS Plugin and adding a title attribute to 
TaskMonitor
A helper class related to V2 (TaskMonitorUtil) has also been added but 
is unused,
and WFS plugin contains code like if TaskMonitor instanceof 
TaskMonitorV2) ...

I would be encline to add setTitle method in TaskMonitor interface in 
order to
simplify the whole API. Any objection ?

Michaël

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351=/4140
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel