Re: [JPP-Devel] SVN: [4821] core/trunk
Hi Stefan, Just made Martin know about this problem. I had a quick look after other parts of OpenJUMP code, but it is not so easy to make sure there will be no side effect elsewhere. Michaël Le 16/02/2016 03:06, Stefan Steiniger a écrit : > Thanks for fixing this Michaël! Do you think that Martin is aware of the > side effect... I mean should it be separately announced on the JTS list > to warn others? > I also wonder if other OJ functions may be affected. But I guess you > checked for that already. > > cheers, > stefan > > On 2/15/16 20:12, jump-pilot-...@lists.sourceforge.net wrote: >> Revision: 4821 >> http://sourceforge.net/p/jump-pilot/code/4821 >> Author: michaudm >> Date: 2016-02-15 23:12:46 + (Mon, 15 Feb 2016) >> Log Message: >> --- >> Fix bug 416 in FillPolygonTool (regression due to JTS change) >> >> Modified Paths: >> -- >> core/trunk/ChangeLog >> >> core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java >> >> Modified: core/trunk/ChangeLog >> === >> --- core/trunk/ChangeLog 2016-02-07 10:15:46 UTC (rev 4820) >> +++ core/trunk/ChangeLog 2016-02-15 23:12:46 UTC (rev 4821) >> @@ -3,7 +3,13 @@ >># 2. make sure that lines break at 80 chars for constricted display >> situations >>#< 80 chars >> --># >> >> -2016-02-01 >> +2016-02-16 mmichaud>> + * Fix bug 416 in FillPolygonTool (regression due to JTS change) >> + >> +2016-02-02 mmichaud >> + * Fix bug #415 throwing exceptions in AttributeTablePanel >> + >> +2016-02-01 mmichaud >> * Add new GroupByPlugIn in Tools>Analysis menu >> >>2016-01-30 >> >> Modified: >> core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java >> === >> --- >> core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java >> 2016-02-07 10:15:46 UTC (rev 4820) >> +++ >> core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java >> 2016-02-15 23:12:46 UTC (rev 4821) >> @@ -122,6 +122,8 @@ >> } >>} catch (Exception ex) { >> ex.printStackTrace(); >> +} finally { >> + INTERRUPTED = false; >>} >> } >>}); >> @@ -226,6 +228,8 @@ >> } >>} catch (Exception e) { >> e.printStackTrace(); >> +} finally { >> + INTERRUPTED = false; >>} >> >>return null; >> @@ -289,7 +293,7 @@ >>Coordinate[] cc = line.getCoordinates(); >>for (int i = 1; i < cc.length; i++) { >> LineString ls = line.getFactory().createLineString( >> - new Coordinate[] { cc[i - 1], cc[i] }); >> + new Coordinate[] { new Coordinate(cc[i - 1]), new >> Coordinate(cc[i]) }); >> ls.normalize(); >> linearComponents.add(ls); >>} >> >> >> -- >> Site24x7 APM Insight: Get Deep Visibility into Application Performance >> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month >> Monitor end-to-end web transactions and take corrective actions now >> Troubleshoot faster and improve end-user experience. Signup Now! >> http://pubads.g.doubleclick.net/gampad/clk?id=272487151=/4140 >> ___ >> Jump-pilot-devel mailing list >> Jump-pilot-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > -- > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151=/4140 > ___ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151=/4140 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] SVN: [4821] core/trunk
Thanks for fixing this Michaël! Do you think that Martin is aware of the side effect... I mean should it be separately announced on the JTS list to warn others? I also wonder if other OJ functions may be affected. But I guess you checked for that already. cheers, stefan On 2/15/16 20:12, jump-pilot-...@lists.sourceforge.net wrote: > Revision: 4821 >http://sourceforge.net/p/jump-pilot/code/4821 > Author: michaudm > Date: 2016-02-15 23:12:46 + (Mon, 15 Feb 2016) > Log Message: > --- > Fix bug 416 in FillPolygonTool (regression due to JTS change) > > Modified Paths: > -- > core/trunk/ChangeLog > > core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java > > Modified: core/trunk/ChangeLog > === > --- core/trunk/ChangeLog 2016-02-07 10:15:46 UTC (rev 4820) > +++ core/trunk/ChangeLog 2016-02-15 23:12:46 UTC (rev 4821) > @@ -3,7 +3,13 @@ > # 2. make sure that lines break at 80 chars for constricted display > situations > #< 80 chars > --># > > -2016-02-01 > +2016-02-16 mmichaud> + * Fix bug 416 in FillPolygonTool (regression due to JTS change) > + > +2016-02-02 mmichaud > + * Fix bug #415 throwing exceptions in AttributeTablePanel > + > +2016-02-01 mmichaud > * Add new GroupByPlugIn in Tools>Analysis menu > > 2016-01-30 > > Modified: > core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java > === > --- > core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java >2016-02-07 10:15:46 UTC (rev 4820) > +++ > core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java >2016-02-15 23:12:46 UTC (rev 4821) > @@ -122,6 +122,8 @@ > } > } catch (Exception ex) { > ex.printStackTrace(); > +} finally { > + INTERRUPTED = false; > } > } > }); > @@ -226,6 +228,8 @@ > } > } catch (Exception e) { > e.printStackTrace(); > +} finally { > + INTERRUPTED = false; > } > > return null; > @@ -289,7 +293,7 @@ > Coordinate[] cc = line.getCoordinates(); > for (int i = 1; i < cc.length; i++) { > LineString ls = line.getFactory().createLineString( > - new Coordinate[] { cc[i - 1], cc[i] }); > + new Coordinate[] { new Coordinate(cc[i - 1]), new > Coordinate(cc[i]) }); > ls.normalize(); > linearComponents.add(ls); > } > > > -- > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151=/4140 > ___ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151=/4140 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
[JPP-Devel] SVN: [4821] core/trunk
Revision: 4821 http://sourceforge.net/p/jump-pilot/code/4821 Author: michaudm Date: 2016-02-15 23:12:46 + (Mon, 15 Feb 2016) Log Message: --- Fix bug 416 in FillPolygonTool (regression due to JTS change) Modified Paths: -- core/trunk/ChangeLog core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java Modified: core/trunk/ChangeLog === --- core/trunk/ChangeLog2016-02-07 10:15:46 UTC (rev 4820) +++ core/trunk/ChangeLog2016-02-15 23:12:46 UTC (rev 4821) @@ -3,7 +3,13 @@ # 2. make sure that lines break at 80 chars for constricted display situations #< 80 chars --># -2016-02-01 +2016-02-16 mmichaud+ * Fix bug 416 in FillPolygonTool (regression due to JTS change) + +2016-02-02 mmichaud + * Fix bug #415 throwing exceptions in AttributeTablePanel + +2016-02-01 mmichaud * Add new GroupByPlugIn in Tools>Analysis menu 2016-01-30 Modified: core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java === --- core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java 2016-02-07 10:15:46 UTC (rev 4820) +++ core/trunk/src/org/openjump/core/ui/plugin/edittoolbox/cursortools/FillPolygonTool.java 2016-02-15 23:12:46 UTC (rev 4821) @@ -122,6 +122,8 @@ } } catch (Exception ex) { ex.printStackTrace(); +} finally { + INTERRUPTED = false; } } }); @@ -226,6 +228,8 @@ } } catch (Exception e) { e.printStackTrace(); +} finally { + INTERRUPTED = false; } return null; @@ -289,7 +293,7 @@ Coordinate[] cc = line.getCoordinates(); for (int i = 1; i < cc.length; i++) { LineString ls = line.getFactory().createLineString( - new Coordinate[] { cc[i - 1], cc[i] }); + new Coordinate[] { new Coordinate(cc[i - 1]), new Coordinate(cc[i]) }); ls.normalize(); linearComponents.add(ls); } -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151=/4140 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel