replication status

2012-09-14 Thread Jun Rao
The remaining jiras for 0.8 are listed in the following dashboard. We will be focusing on the blocker jiras first. Contributions are welcome. We hope to have an early version for people to try out in mid to late Oct. https://cwiki.apache.org/confluence/display/KAFKA/Kafka+replication+development

[jira] [Commented] (KAFKA-133) Publish kafka jar to a public maven repository

2012-09-14 Thread Otis Gospodnetic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456309#comment-13456309 ] Otis Gospodnetic commented on KAFKA-133: +1 for this. Funny, it looks like it has

[jira] [Updated] (KAFKA-500) javaapi support for getTopoicMetaData

2012-09-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-500: Attachment: kafka-500-v1.patch 1. Created java apis for TopicMetadataRequest and TopicMetadataRespon

[jira] [Assigned] (KAFKA-500) javaapi support for getTopoicMetaData

2012-09-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-500: --- Assignee: Swapnil Ghike > javaapi support for getTopoicMetaData >

[jira] [Updated] (KAFKA-391) Producer request and response classes should use maps

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-391: - Attachment: KAFKA-391-v4.patch Here is the rebased patch. I also had to include a small edit to ReplicaFe

[jira] [Resolved] (KAFKA-6) Support replicating from more than 1 remote kafka cluster

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-6. Resolution: Invalid (was: Unresolved) > Support replicating from more than 1 remote kafka cluster > -

[jira] [Resolved] (KAFKA-401) producer-perf-test does not enforce manditory arguments

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-401. -- Resolution: Duplicate Should be covered by KAFKA-408 > producer-perf-test does not enfo

[jira] [Updated] (KAFKA-435) Keep track of the transient test failure for Kafka-343 on Apache Jenkins

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-435: - Affects Version/s: 0.8 > Keep track of the transient test failure for Kafka-343 on Apache Jenkins > --

[jira] [Updated] (KAFKA-430) Improve the "waitUntilLeaderIsElectedOrChanged" function in TestUtils class

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-430: - Affects Version/s: 0.8 > Improve the "waitUntilLeaderIsElectedOrChanged" function in TestUtils class >

[jira] [Updated] (KAFKA-484) Move log settings in the beginning of system_test_runner.py to an external log properties file

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-484: - Affects Version/s: 0.8 Labels: replication-testing (was: ) > Move log settings in the

[jira] [Updated] (KAFKA-402) Adding handling various kind of exception support at server side

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-402: - Affects Version/s: 0.8 > Adding handling various kind of exception support at server side > --

[jira] [Updated] (KAFKA-485) Support MacOS for this test framework

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-485: - Affects Version/s: 0.8 Fix Version/s: 0.8 Labels: replication-testing (was: )

[jira] [Updated] (KAFKA-485) Support MacOS for this test framework

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-485: - Description: John Fung (was: Currently this test framework doesn't work properly in MacOS due to the diff

[jira] [Updated] (KAFKA-485) Support MacOS for this test framework

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-485: - Description: Currently this test framework doesn't work properly in MacOS due to the different "ps" argume

[jira] [Updated] (KAFKA-488) Port Mirroring System Test to this python system test framework

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-488: - Affects Version/s: 0.8 Fix Version/s: 0.8 Labels: replication-testing (was: )

[jira] [Updated] (KAFKA-492) Sometimes the python system test framework doesn't terminate all running processes

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-492: - Affects Version/s: 0.8 Fix Version/s: 0.8 Labels: replication-testing (was: )

[jira] [Updated] (KAFKA-478) Move start_consumer & start_producer inside "start_entity_in_background"

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-478: - Affects Version/s: 0.8 Fix Version/s: 0.8 Labels: replication-testing (was: )

[jira] [Updated] (KAFKA-494) Relative paths should be used for svg URLs in dashboards html

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-494: - Affects Version/s: 0.8 Fix Version/s: 0.8 Labels: replication-testing (was: )

[jira] [Updated] (KAFKA-494) Relative paths should be used for svg URLs in dashboards html

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-494: - Resolution: Fixed Status: Resolved (was: Patch Available) Closing - per comment.

[jira] [Updated] (KAFKA-502) Simplify setup / initialization in replication_basic_test.py

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-502: - Affects Version/s: 0.8 Fix Version/s: 0.8 Labels: replication-testing (was: )

[jira] [Updated] (KAFKA-503) Support "testcase_to_run" or "testcase_to_skip"

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-503: - Affects Version/s: 0.8 Fix Version/s: 0.8 Labels: replication-testing (was: )

[jira] [Updated] (KAFKA-507) Shut down ZK last to avoid hanging brokers running processes

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-507: - Affects Version/s: 0.8 Fix Version/s: 0.8 Labels: replication-testing (was: )

[jira] [Updated] (KAFKA-514) Replication with Leader Failure Test: Log segment files checksum mismatch

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-514: - Labels: replication-testing (was: ) > Replication with Leader Failure Test: Log segment files checksu

[jira] [Updated] (KAFKA-516) Consider catching all exceptions in ShutdownableThread

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-516: - Labels: bugs (was: ) > Consider catching all exceptions in ShutdownableThread > -

[jira] [Updated] (KAFKA-517) Ensure that we escape the metric names if they include user strings

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-517: - Labels: bugs (was: ) > Ensure that we escape the metric names if they include user strings >

[jira] [Updated] (KAFKA-516) Consider catching all exceptions in ShutdownableThread

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-516: - Affects Version/s: 0.8 Fix Version/s: 0.8 > Consider catching all exceptions in ShutdownableTh

[jira] [Updated] (KAFKA-517) Ensure that we escape the metric names if they include user strings

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-517: - Affects Version/s: 0.8 > Ensure that we escape the metric names if they include user strings > ---

[jira] [Updated] (KAFKA-482) Make producer to run for the entire duration of the System Test

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-482: - Affects Version/s: 0.8 Fix Version/s: 0.8 > Make producer to run for the entire duration of th

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-513: - Affects Version/s: 0.8 Fix Version/s: 0.8 > Add state change log to Kafka brokers > --

[jira] [Updated] (KAFKA-514) Replication with Leader Failure Test: Log segment files checksum mismatch

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-514: - Priority: Blocker (was: Major) Affects Version/s: 0.8 Fix Version/s: 0.8 > Repli

[jira] [Commented] (KAFKA-515) Log cleanup can close a file channel opnened by Log.read before the transfer completes

2012-09-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456210#comment-13456210 ] Jay Kreps commented on KAFKA-515: - A simpler approach then reference counting would be to d

[jira] [Commented] (KAFKA-506) Store logical offset in log

2012-09-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456207#comment-13456207 ] Jay Kreps commented on KAFKA-506: - I am going to begin phase two of this, implementing the

[jira] [Updated] (KAFKA-506) Store logical offset in log

2012-09-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-506: Attachment: KAFKA-506-v1.patch Updated the patch. This patch fixes the remaining failing tests and correctly

[jira] [Created] (KAFKA-517) Ensure that we escape the metric names if they include user strings

2012-09-14 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-517: --- Summary: Ensure that we escape the metric names if they include user strings Key: KAFKA-517 URL: https://issues.apache.org/jira/browse/KAFKA-517 Project: Kafka Issue

[jira] [Updated] (KAFKA-463) log.truncateTo needs to handle targetOffset smaller than the lowest offset in the log

2012-09-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-463: Attachment: kafka-463-v3.patch 20.1. Letting the constructor be as it is as discussed. 20.2. Made t

[jira] [Created] (KAFKA-516) Consider catching all exceptions in ShutdownableThread

2012-09-14 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-516: --- Summary: Consider catching all exceptions in ShutdownableThread Key: KAFKA-516 URL: https://issues.apache.org/jira/browse/KAFKA-516 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-499) Refactor controller state machine

2012-09-14 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-499: Attachment: kafka-499-v2.patch Rebased and fixed a minor JMX bean issue > Refactor

[jira] [Created] (KAFKA-515) Log cleanup can close a file channel opnened by Log.read before the transfer completes

2012-09-14 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-515: --- Summary: Log cleanup can close a file channel opnened by Log.read before the transfer completes Key: KAFKA-515 URL: https://issues.apache.org/jira/browse/KAFKA-515 Proj

[jira] [Closed] (KAFKA-449) Leader election test

2012-09-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-449. - > Leader election test > > > Key: KAFKA-449 > URL: https://is

[jira] [Updated] (KAFKA-512) Remove checksum from ByteBufferMessageSet.iterator

2012-09-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-512: -- Priority: Blocker (was: Major) Labels: bugs (was: ) > Remove checksum from ByteBufferMessageSet.iter

Re: Coding convention: tuples vs case classes

2012-09-14 Thread Neha Narkhede
+1 On Fri, Sep 14, 2012 at 7:50 AM, Joe Stein wrote: > +1 > > On Thu, Sep 13, 2012 at 11:51 PM, Jakob Homan wrote: > >> +1 >> >> On Thu, Sep 13, 2012 at 5:38 PM, Joel Koshy wrote: >> >> > In KAFKA-391 I tried switching from (topic, partition) tuples to a >> > TopicPartition case class in the pr

[jira] [Created] (KAFKA-514) Replication with Leader Failure Test: Log segment files checksum mismatch

2012-09-14 Thread John Fung (JIRA)
John Fung created KAFKA-514: --- Summary: Replication with Leader Failure Test: Log segment files checksum mismatch Key: KAFKA-514 URL: https://issues.apache.org/jira/browse/KAFKA-514 Project: Kafka

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2012-09-14 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-513: Description: Once KAFKA-499 is checked in, every controller to broker communication can be modelled

[jira] [Created] (KAFKA-513) Add state change log to Kafka brokers

2012-09-14 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-513: --- Summary: Add state change log to Kafka brokers Key: KAFKA-513 URL: https://issues.apache.org/jira/browse/KAFKA-513 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-344) migration tool from 0.7 to 0.8

2012-09-14 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-344: Parent Issue: KAFKA-327 (was: KAFKA-50) > migration tool from 0.7 to 0.8 >

Re: InvalidMessageException vs InvalidMessageSizeException vs MessageSizeTooLargeException

2012-09-14 Thread Jay Kreps
Makes sense, I will leave it for now. -Jay On Fri, Sep 14, 2012 at 10:14 AM, Jun Rao wrote: > The current semantics of those exceptions are: > InvalidMessageException: message is corrupted (crc doesn't match payload) > InvalidMessageSizeException: message size is larger than the payload size. >

Re: Broker computes message crcs twice

2012-09-14 Thread Jun Rao
Yes, we should remove the crc check in the iterator of ByteBufferMessageSet. Log.append already checks crc, which protects the server. Consumer, if wants to, could explicitly check the crc on each message on its own. Thanks, Jun On Fri, Sep 14, 2012 at 9:19 AM, Jay Kreps wrote: > Okay, I check

[jira] [Updated] (KAFKA-449) Leader election test

2012-09-14 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-449: Resolution: Fixed Status: Resolved (was: Patch Available) Just committed this

[jira] [Commented] (KAFKA-449) Leader election test

2012-09-14 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455952#comment-13455952 ] Neha Narkhede commented on KAFKA-449: - +1 on v2. Thanks for the patch !

Re: InvalidMessageException vs InvalidMessageSizeException vs MessageSizeTooLargeException

2012-09-14 Thread Jun Rao
The current semantics of those exceptions are: InvalidMessageException: message is corrupted (crc doesn't match payload) InvalidMessageSizeException: message size is larger than the payload size. This is mostly used on the consumer side in case we fetch a chunk of bytes on a wrong starting offset.

[jira] [Updated] (KAFKA-499) Refactor controller state machine

2012-09-14 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-499: Attachment: (was: kafka-499-v1.patch) > Refactor controller state machine > ---

[jira] [Commented] (KAFKA-463) log.truncateTo needs to handle targetOffset smaller than the lowest offset in the log

2012-09-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455942#comment-13455942 ] Jun Rao commented on KAFKA-463: --- Thanks for patch v2. Some more comments: 20. Log: 20.1 roll

[jira] [Updated] (KAFKA-499) Refactor controller state machine

2012-09-14 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-499: Attachment: kafka-499-v1.patch > Refactor controller state machine > --

[jira] [Updated] (KAFKA-499) Refactor controller state machine

2012-09-14 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-499: Status: Patch Available (was: Open) > Refactor controller state machine >

[jira] [Updated] (KAFKA-499) Refactor controller state machine

2012-09-14 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-499: Attachment: kafka-499-v1.patch This patch refactors (almost rewrites) the controller. The controller

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455928#comment-13455928 ] Joel Koshy commented on KAFKA-391: -- Ok nm - I see it's because we removed SyncProducer and

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2012-09-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455927#comment-13455927 ] Joel Koshy commented on KAFKA-391: -- 30 - Why should it be removed? > Prod

[jira] [Updated] (KAFKA-512) Remove checksum from ByteBufferMessageSet.iterator

2012-09-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-512: Summary: Remove checksum from ByteBufferMessageSet.iterator (was: Remove checksum from ByteBufferMessageSet

[jira] [Created] (KAFKA-512) Remove checksum from ByteBufferMessageSet

2012-09-14 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-512: --- Summary: Remove checksum from ByteBufferMessageSet Key: KAFKA-512 URL: https://issues.apache.org/jira/browse/KAFKA-512 Project: Kafka Issue Type: Bug Repor

Re: Broker computes message crcs twice

2012-09-14 Thread Jay Kreps
Okay, I checked on this. The producer computes the checksum twice, which is once too many. The server computes the checksum an astounding 39 times in 0.8 branch! I think this answers the earlier questions: The right thing to do is clearly to remove the check from the iterator as people are iteratin

Re: Broker computes message crcs twice

2012-09-14 Thread Jay Kreps
I actually think the validBytes() call is looping and hence computing CRCs too. So actually at least three times. -Jay On Fri, Sep 14, 2012 at 9:10 AM, Jay Kreps wrote: > Hey guys, > > I noticed that our ByteBufferMessageSet iterator computes the message CRC > on iteration. Log.append also loop

Broker computes message crcs twice

2012-09-14 Thread Jay Kreps
Hey guys, I noticed that our ByteBufferMessageSet iterator computes the message CRC on iteration. Log.append also loops through all messages and checks the same checksum. This means we are effectively computing the CRC32 twice inside Log.append (we may actually be doing it more than that we would

Re: ??? 0.7.2 before 0.8 ???

2012-09-14 Thread Joe Stein
On Thu, Sep 13, 2012 at 10:35 PM, Chris Burroughs wrote: > On 2012-09-13 13:15, Joe Stein wrote: > > I am working on a new product that has 0.7.1 in it don't mind even > > pushing 0.7.2 into or 0.8 and releasing both in succession. > > Do yo want help with the mechanics of the release itself? >

Re: Coding convention: tuples vs case classes

2012-09-14 Thread Joe Stein
+1 On Thu, Sep 13, 2012 at 11:51 PM, Jakob Homan wrote: > +1 > > On Thu, Sep 13, 2012 at 5:38 PM, Joel Koshy wrote: > > > In KAFKA-391 I tried switching from (topic, partition) tuples to a > > TopicPartition case class in the producer/fetch request handling code. I > > think it helped quite a b