[jira] [Commented] (KAFKA-301) Implement the broker startup procedure

2012-04-11 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251734#comment-13251734 ] Neha Narkhede commented on KAFKA-301: - I think one thing that can be improved is the st

[jira] [Commented] (KAFKA-48) Implement optional "long poll" support in fetch request

2012-04-10 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250912#comment-13250912 ] Neha Narkhede commented on KAFKA-48: This patch looks very good. Here are a few question

[jira] [Commented] (KAFKA-302) Implement the become leader and become follower state change operations

2012-04-09 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249965#comment-13249965 ] Neha Narkhede commented on KAFKA-302: - This JIRA implements the becomeLeader() and beco

[jira] [Commented] (KAFKA-301) Implement the broker startup procedure

2012-04-07 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249448#comment-13249448 ] Neha Narkhede commented on KAFKA-301: - The refactoring in KAFKA-307 attempted to reduce

[jira] [Commented] (KAFKA-320) testZKSendWithDeadBroker fails intermittently due to ZKNodeExistsException

2012-04-06 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249098#comment-13249098 ] Neha Narkhede commented on KAFKA-320: - After applying the v3-delta patch, I see that so

[jira] [Commented] (KAFKA-326) CallbackHandler.afterDequeuingExistingData is not called during event queue timeout

2012-04-06 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248437#comment-13248437 ] Neha Narkhede commented on KAFKA-326: - +1. Looks good > CallbackHandle

[jira] [Commented] (KAFKA-320) testZKSendWithDeadBroker fails intermittently due to ZKNodeExistsException

2012-04-02 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244425#comment-13244425 ] Neha Narkhede commented on KAFKA-320: - Thanks for the review! 4. Regarding this, what

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-29 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241902#comment-13241902 ] Neha Narkhede commented on KAFKA-49: +1. Thanks for incorporating the review suggestions

[jira] [Commented] (KAFKA-323) Add the ability to use the async producer in the Log4j appender

2012-03-29 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241585#comment-13241585 ] Neha Narkhede commented on KAFKA-323: - Thanks for the patch ! Would you mind attaching

[jira] [Commented] (KAFKA-320) testZKSendWithDeadBroker fails intermittently due to ZKNodeExistsException

2012-03-29 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241383#comment-13241383 ] Neha Narkhede commented on KAFKA-320: - Can someone review this ? > tes

[jira] [Commented] (KAFKA-249) Separate out Kafka mirroring into a stand-alone app

2012-03-28 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240782#comment-13240782 ] Neha Narkhede commented on KAFKA-249: - > 5. There are several new class variables calle

[jira] [Commented] (KAFKA-249) Separate out Kafka mirroring into a stand-alone app

2012-03-28 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240616#comment-13240616 ] Neha Narkhede commented on KAFKA-249: - This is a cool feature. Thanks for the patch !

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-28 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240512#comment-13240512 ] Neha Narkhede commented on KAFKA-49: Prashanth, thanks for resolving KAFKA-305 ! Would y

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-26 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238873#comment-13238873 ] Neha Narkhede commented on KAFKA-305: - I found the zookeeper related problem, filed KAF

[jira] [Commented] (KAFKA-301) Implement the broker startup procedure

2012-03-24 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237757#comment-13237757 ] Neha Narkhede commented on KAFKA-301: - Sounds good. Probably letting the JIRA and relat

[jira] [Commented] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-03-24 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237724#comment-13237724 ] Neha Narkhede commented on KAFKA-46: Started work on this, will upload a patch, once KAF

[jira] [Commented] (KAFKA-301) Implement the broker startup procedure

2012-03-23 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237404#comment-13237404 ] Neha Narkhede commented on KAFKA-301: - Yeah, after finishing up on KAFKA-300, I took up

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-23 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236942#comment-13236942 ] Neha Narkhede commented on KAFKA-305: - v2 looks good. Regarding the test failure, I d

[jira] [Commented] (KAFKA-307) Refactor server code to remove interdependencies between LogManager and KafkaZooKeeper

2012-03-22 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236178#comment-13236178 ] Neha Narkhede commented on KAFKA-307: - 3. Yeah, I thought about this, but then that req

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-22 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235643#comment-13235643 ] Neha Narkhede commented on KAFKA-305: - Prashanth, Thanks for the patch. A couple of su

[jira] [Commented] (KAFKA-312) Add 'reset' operation for AsyncProducerDroppedEvents

2012-03-21 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234489#comment-13234489 ] Neha Narkhede commented on KAFKA-312: - +1. This is useful > Add 'reset

[jira] [Commented] (KAFKA-308) Corrupted message stored in log segment on disk

2012-03-17 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232111#comment-13232111 ] Neha Narkhede commented on KAFKA-308: - The corrupted log segment is uploaded here - ht

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-15 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230603#comment-13230603 ] Neha Narkhede commented on KAFKA-49: 1. I'm refactoring some part of DefaultEventHandler

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-14 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229905#comment-13229905 ] Neha Narkhede commented on KAFKA-49: Sorry for visiting this late. I have a few question

[jira] [Commented] (KAFKA-44) Various ZK listeners to support intra-cluster replication

2012-03-12 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228083#comment-13228083 ] Neha Narkhede commented on KAFKA-44: This JIRA can implement the stateChangeListener() a

[jira] [Commented] (KAFKA-293) Allow to configure all broker ids at once similar to how zookeeper handles server ids

2012-03-12 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228073#comment-13228073 ] Neha Narkhede commented on KAFKA-293: - I like the meta.properties approach, better than

[jira] [Commented] (KAFKA-45) Broker startup, leader election, becoming a leader/follower for intra-cluster replication

2012-03-12 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228011#comment-13228011 ] Neha Narkhede commented on KAFKA-45: Here is something to think about wrt to leader elec

[jira] [Commented] (KAFKA-273) Occassional GZIP errors on the server while writing compressed data to disk

2012-03-12 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227839#comment-13227839 ] Neha Narkhede commented on KAFKA-273: - Have run the system test with message size = 100

[jira] [Commented] (KAFKA-220) LogManager test fails on linux

2012-03-07 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225022#comment-13225022 ] Neha Narkhede commented on KAFKA-220: - +1 > LogManager test fails on l

[jira] [Commented] (KAFKA-273) Occassional GZIP errors on the server while writing compressed data to disk

2012-03-06 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223806#comment-13223806 ] Neha Narkhede commented on KAFKA-273: - Jun, I am not sure its the same issue. See this

[jira] [Commented] (KAFKA-273) Occassional GZIP errors on the server while writing compressed data to disk

2012-03-06 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223476#comment-13223476 ] Neha Narkhede commented on KAFKA-273: - We've seen this error very occasionally, but in

[jira] [Commented] (KAFKA-292) broker deletes all file segments when cleaning up an empty log segment

2012-03-05 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222864#comment-13222864 ] Neha Narkhede commented on KAFKA-292: - +1 on v2. Good catch ! > broker

[jira] [Commented] (KAFKA-292) broker deletes all file segments when cleaning up an empty log segment

2012-03-05 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222689#comment-13222689 ] Neha Narkhede commented on KAFKA-292: - It will be very useful to have a unit test for t

[jira] [Commented] (KAFKA-279) kafka-console-producer does not take in customized values of --batch-size or --timeout

2012-03-02 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221349#comment-13221349 ] Neha Narkhede commented on KAFKA-279: - Milind, does the attached patch fix your problem

[jira] [Commented] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-03-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220583#comment-13220583 ] Neha Narkhede commented on KAFKA-46: >> Should this be broken down into two sub tasks: O

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220436#comment-13220436 ] Neha Narkhede commented on KAFKA-49: KAFKA-239 is complete and KAFKA-240 is almost there

[jira] [Commented] (KAFKA-50) kafka intra-cluster replication support

2012-03-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220410#comment-13220410 ] Neha Narkhede commented on KAFKA-50: Cool, so I was thinking if the original design was

[jira] [Commented] (KAFKA-239) Wire existing producer and consumer to use the new ZK data structure

2012-03-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220364#comment-13220364 ] Neha Narkhede commented on KAFKA-239: - ah, speaking of different perspectives, which is

[jira] [Commented] (KAFKA-44) Various ZK listeners to support intra-cluster replication

2012-03-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220307#comment-13220307 ] Neha Narkhede commented on KAFKA-44: This approach of having a queue of state change req

[jira] [Commented] (KAFKA-50) kafka intra-cluster replication support

2012-03-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220268#comment-13220268 ] Neha Narkhede commented on KAFKA-50: Can the design be moved to the Kafka wiki instead o

[jira] [Commented] (KAFKA-239) Wire existing producer and consumer to use the new ZK data structure

2012-03-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220226#comment-13220226 ] Neha Narkhede commented on KAFKA-239: - >> 11. TestUtils: why do we need checkSetEqual?

[jira] [Commented] (KAFKA-239) Wire existing producer and consumer to use the new ZK data structure

2012-03-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220144#comment-13220144 ] Neha Narkhede commented on KAFKA-239: - There is something wierd happening with the Auto

[jira] [Commented] (KAFKA-290) use propertyExists to test if both broker.list and zk.connect are present

2012-02-28 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218844#comment-13218844 ] Neha Narkhede commented on KAFKA-290: - +1 on v3. > use propertyExists

[jira] [Commented] (KAFKA-290) use propertyExists to test if both broker.list and zk.connect are present

2012-02-28 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218826#comment-13218826 ] Neha Narkhede commented on KAFKA-290: - But, I think the check for both properties absen

[jira] [Commented] (KAFKA-290) use propertyExists to test if both broker.list and zk.connect are present

2012-02-28 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218792#comment-13218792 ] Neha Narkhede commented on KAFKA-290: - There is another place where it will be worthwhi

[jira] [Commented] (KAFKA-286) consumer sometimes don't release partition ownership properly in ZK during rebalance

2012-02-27 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217395#comment-13217395 ] Neha Narkhede commented on KAFKA-286: - Yes, missed the fact that after releasing the pa

[jira] [Commented] (KAFKA-286) consumer sometimes don't release partition ownership properly in ZK during rebalance

2012-02-27 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217356#comment-13217356 ] Neha Narkhede commented on KAFKA-286: - That's a good change and will handle the majorit

[jira] [Commented] (KAFKA-286) consumer sometimes don't release partition ownership properly in ZK during rebalance

2012-02-26 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217050#comment-13217050 ] Neha Narkhede commented on KAFKA-286: - Wondering if the patch can get the consumer into

[jira] [Commented] (KAFKA-283) add jmx beans in broker to track # of failed requests

2012-02-25 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216531#comment-13216531 ] Neha Narkhede commented on KAFKA-283: - +1. This is very useful > add j

[jira] [Commented] (KAFKA-265) Add a queue of zookeeper notifications in the zookeeper consumer to reduce the number of rebalancing attempts

2012-02-16 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209846#comment-13209846 ] Neha Narkhede commented on KAFKA-265: - +1. Doesn't the test in system_test/broker_failu

[jira] [Commented] (KAFKA-265) Add a queue of zookeeper notifications in the zookeeper consumer to reduce the number of rebalancing attempts

2012-02-15 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208848#comment-13208848 ] Neha Narkhede commented on KAFKA-265: - Subtle, but critical :-) +1 >

[jira] [Commented] (KAFKA-272) add JMX on broker to track bytes/messages per topic

2012-02-15 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208749#comment-13208749 ] Neha Narkhede commented on KAFKA-272: - +1 > add JMX on broker to track

[jira] [Commented] (KAFKA-45) Broker startup, leader election, becoming a leader/follower for intra-cluster replication

2012-02-15 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208696#comment-13208696 ] Neha Narkhede commented on KAFKA-45: Prashanth, Thanks for helping out on replication a

[jira] [Commented] (KAFKA-272) add JMX on broker to track bytes/messages per topic

2012-02-15 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208659#comment-13208659 ] Neha Narkhede commented on KAFKA-272: - Does the per topic bean only count messages prod

[jira] [Commented] (KAFKA-272) add JMX on broker to track bytes/messages per topic

2012-02-15 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208656#comment-13208656 ] Neha Narkhede commented on KAFKA-272: - +1 > add JMX on broker to trac

[jira] [Commented] (KAFKA-265) Add a queue of zookeeper notifications in the zookeeper consumer to reduce the number of rebalancing attempts

2012-02-13 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207200#comment-13207200 ] Neha Narkhede commented on KAFKA-265: - +1 for v2. Thanks for accomodating the change

[jira] [Commented] (KAFKA-265) Add a queue of zookeeper notifications in the zookeeper consumer to reduce the number of rebalancing attempts

2012-02-09 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204981#comment-13204981 ] Neha Narkhede commented on KAFKA-265: - If the queue is full, the ZKclient listener can

[jira] [Commented] (KAFKA-262) Bug in the consumer rebalancing logic causes one consumer to release partitions that it does not own

2012-02-08 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203816#comment-13203816 ] Neha Narkhede commented on KAFKA-262: - 1. Will change that before committing the patch

[jira] [Commented] (KAFKA-263) Enhance single host broker failure test to have 2 topics with uneven distribution on the source brokers

2012-02-07 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202547#comment-13202547 ] Neha Narkhede commented on KAFKA-263: - +1 on v2. Thanks for working on this patch !

[jira] [Commented] (KAFKA-253) Refactor the async producer to have only one queue instead of one queue per broker in a Kafka cluster

2012-02-07 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202541#comment-13202541 ] Neha Narkhede commented on KAFKA-253: - Jun, could you please merge v5 to the 0.8 branch

[jira] [Commented] (KAFKA-264) Change the consumer side load balancing and distributed co-ordination to use a consumer co-ordinator

2012-02-06 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201697#comment-13201697 ] Neha Narkhede commented on KAFKA-264: - If a process goes down, the ephemeral node for /

[jira] [Commented] (KAFKA-264) Change the consumer side load balancing and distributed co-ordination to use a consumer co-ordinator

2012-02-06 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201672#comment-13201672 ] Neha Narkhede commented on KAFKA-264: - The consumer co-ordinator itself is highly avail

[jira] [Commented] (KAFKA-253) Refactor the async producer to have only one queue instead of one queue per broker in a Kafka cluster

2012-02-06 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201655#comment-13201655 ] Neha Narkhede commented on KAFKA-253: - ProducerMethodsTest needs to be removed. Other t

[jira] [Commented] (KAFKA-263) Enhance single host broker failure test to have 2 topics with uneven distribution on the source brokers

2012-02-06 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201466#comment-13201466 ] Neha Narkhede commented on KAFKA-263: - I took a quick look at the patch and have one su

[jira] [Commented] (KAFKA-256) Bug in the consumer rebalancing logic leads to the consumer not pulling data from some partitions

2012-02-02 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199446#comment-13199446 ] Neha Narkhede commented on KAFKA-256: - 1. That is the bug I was referring to in my prev

[jira] [Commented] (KAFKA-256) Bug in the consumer rebalancing logic leads to the consumer not pulling data from some partitions

2012-02-02 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199409#comment-13199409 ] Neha Narkhede commented on KAFKA-256: - I found a bug in the v3 patch. The reflectPartit

[jira] [Commented] (KAFKA-261) Corrupted request shuts down the broker

2012-02-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198568#comment-13198568 ] Neha Narkhede commented on KAFKA-261: - +1 > Corrupted request shuts do

[jira] [Commented] (KAFKA-253) Refactor the async producer to have only one queue instead of one queue per broker in a Kafka cluster

2012-02-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198186#comment-13198186 ] Neha Narkhede commented on KAFKA-253: - That is a pretty useful refactoring patch ! I ha

[jira] [Commented] (KAFKA-257) Hadoop producer should use software load balancer

2012-01-29 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195883#comment-13195883 ] Neha Narkhede commented on KAFKA-257: - Thanks for the updated patch Sam. 1. The broker

[jira] [Commented] (KAFKA-256) Bug in the consumer rebalancing logic leads to the consumer not pulling data from some partitions

2012-01-29 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195816#comment-13195816 ] Neha Narkhede commented on KAFKA-256: - You have a good point about the tools package. T

[jira] [Commented] (KAFKA-257) Hadoop producer should use software load balancer

2012-01-26 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194032#comment-13194032 ] Neha Narkhede commented on KAFKA-257: - Thanks for the patch Sam ! Overall, it looks gre

[jira] [Commented] (KAFKA-253) Refactor the async producer to have only one queue instead of one queue per broker in a Kafka cluster

2012-01-24 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192737#comment-13192737 ] Neha Narkhede commented on KAFKA-253: - Here are some details on a potential refactoring

[jira] [Commented] (KAFKA-238) add a getTopicMetaData method in broker and expose it to producer

2012-01-24 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192495#comment-13192495 ] Neha Narkhede commented on KAFKA-238: - It was intentional. The zk dependency removal an

[jira] [Commented] (KAFKA-202) Make the request processing in kafka asynchonous

2012-01-13 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185862#comment-13185862 ] Neha Narkhede commented on KAFKA-202: - My bad. Forgot to do the svn add on those. Fixed

[jira] [Commented] (KAFKA-237) create/delete ZK path for a topic in an admin tool

2012-01-13 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185823#comment-13185823 ] Neha Narkhede commented on KAFKA-237: - +1. PartitionMetaData can be a case class, but

[jira] [Commented] (KAFKA-237) create/delete ZK path for a topic in an admin tool

2012-01-12 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185397#comment-13185397 ] Neha Narkhede commented on KAFKA-237: - Thanks for uploading v2. 5. Today, we expose t

[jira] [Commented] (KAFKA-245) upgrade to zkclient 0.1

2012-01-12 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185231#comment-13185231 ] Neha Narkhede commented on KAFKA-245: - >From Maven, the date is 04-13-2011. ( >http://

[jira] [Commented] (KAFKA-232) ConsumerConnector has no access to "getOffsetsBefore"

2012-01-12 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185223#comment-13185223 ] Neha Narkhede commented on KAFKA-232: - I think here is how that can work - Say we enab

[jira] [Commented] (KAFKA-237) create/delete ZK path for a topic in an admin tool

2012-01-12 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185158#comment-13185158 ] Neha Narkhede commented on KAFKA-237: - Took a look at the patch. Good to see work start

[jira] [Commented] (KAFKA-244) Improve log4j appender to use kafka.producer.Producer, and support zk.connect|broker.list options

2012-01-11 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184733#comment-13184733 ] Neha Narkhede commented on KAFKA-244: - We had the host and port options before we porte

[jira] [Commented] (KAFKA-244) Improve log4j appender to use kafka.producer.Producer, and support zk.connect|broker.list options

2012-01-11 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184720#comment-13184720 ] Neha Narkhede commented on KAFKA-244: - Thanks for uploading the patch. A couple of comm

[jira] [Commented] (KAFKA-244) Improve log4j appender to use kafka.producer.Producer, and support zk.connect|broker.list options

2012-01-11 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184406#comment-13184406 ] Neha Narkhede commented on KAFKA-244: - Thanks for getting started on this. I have a cou

[jira] [Commented] (KAFKA-10) Kafka deployment on EC2 should be WHIRR based, instead of current contrib/deploy code based solution

2012-01-10 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183697#comment-13183697 ] Neha Narkhede commented on KAFKA-10: You are right. This JIRA is just a placeholder and

[jira] [Commented] (KAFKA-245) upgrade to zkclient 0.1

2012-01-10 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183687#comment-13183687 ] Neha Narkhede commented on KAFKA-245: - Thanks for the patch ! One thing missing in ther

[jira] [Commented] (KAFKA-218) ZOOKEEPER-961 is nasty, upgrade to zk 3.3.4

2012-01-10 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183659#comment-13183659 ] Neha Narkhede commented on KAFKA-218: - +1. Thanks for the patch ! > ZO

[jira] [Commented] (KAFKA-202) Make the request processing in kafka asynchonous

2012-01-10 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183482#comment-13183482 ] Neha Narkhede commented on KAFKA-202: - I tried to apply the v5 patch and couldn't find

[jira] [Commented] (KAFKA-238) add a getTopicMetaData method in broker and expose it to producer

2012-01-09 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182823#comment-13182823 ] Neha Narkhede commented on KAFKA-238: - I see Jay's point about making this API general

[jira] [Commented] (KAFKA-228) Reduce duplicate messages served by the kafka consumer for uncompressed topics to 0

2012-01-05 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181038#comment-13181038 ] Neha Narkhede commented on KAFKA-228: - kafka-228-v2.patch had a bunch of compilation er

[jira] [Commented] (KAFKA-227) Add Broker Failure Test for a Single Host

2012-01-05 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181000#comment-13181000 ] Neha Narkhede commented on KAFKA-227: - I made the svn propset changes and committed thi

[jira] [Commented] (KAFKA-227) Add Broker Failure Test for a Single Host

2012-01-05 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180801#comment-13180801 ] Neha Narkhede commented on KAFKA-227: - This is a great patch ! Just one comment. The *s

[jira] [Commented] (KAFKA-234) Make backoff time during consumer rebalance configurable

2012-01-04 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180040#comment-13180040 ] Neha Narkhede commented on KAFKA-234: - +1 > Make backoff time during c

[jira] [Commented] (KAFKA-230) Update website documentation to include changes in 0.7.0 release

2012-01-04 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179636#comment-13179636 ] Neha Narkhede commented on KAFKA-230: - Chris, Kafka currently does not have a directory

[jira] [Commented] (KAFKA-233) The producer's load balancing logic can send requests to dead brokers, when using the async producer option

2012-01-03 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178954#comment-13178954 ] Neha Narkhede commented on KAFKA-233: - Al though this JIRA is marked with the newbie ta

[jira] [Commented] (KAFKA-186) no clean way to getCompressionCodec from Java-the-language

2012-01-03 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178950#comment-13178950 ] Neha Narkhede commented on KAFKA-186: - Chris, Based on the discussion above, do you fe

[jira] [Commented] (KAFKA-209) Remove empty directory when no log segments remain

2012-01-03 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178951#comment-13178951 ] Neha Narkhede commented on KAFKA-209: - Taylor, Do you see this behavior with trunk or

[jira] [Commented] (KAFKA-173) Support encoding for non ascii characters

2012-01-03 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178948#comment-13178948 ] Neha Narkhede commented on KAFKA-173: - Ping. Can anybody help review this ?

[jira] [Commented] (KAFKA-205) Audit swallowing of exceptions/throwables

2012-01-03 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178947#comment-13178947 ] Neha Narkhede commented on KAFKA-205: - Chris, Do you think we still have this problem

[jira] [Commented] (KAFKA-133) Publish kafka jar to a public maven repository

2012-01-03 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178829#comment-13178829 ] Neha Narkhede commented on KAFKA-133: - Patricio, This ticket is blocked on KAFKA-134.

[jira] [Commented] (KAFKA-231) avoid logging stacktrace directly

2012-01-02 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178590#comment-13178590 ] Neha Narkhede commented on KAFKA-231: - +1 > avoid logging stacktrace d

[jira] [Commented] (KAFKA-228) Reduce duplicate messages served by the kafka consumer for uncompressed topics to 0

2012-01-02 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178585#comment-13178585 ] Neha Narkhede commented on KAFKA-228: - 2.1 Fair enough. I'll move it out of commitOffse

  1   2   >