+1
On Fri, Sep 14, 2012 at 7:50 AM, Joe Stein wrote:
> +1
>
> On Thu, Sep 13, 2012 at 11:51 PM, Jakob Homan wrote:
>
>> +1
>>
>> On Thu, Sep 13, 2012 at 5:38 PM, Joel Koshy wrote:
>>
>> > In KAFKA-391 I tried switching from (topic, partition) tuples to a
>> > TopicPartition case class in the pr
+1
On Thu, Sep 13, 2012 at 11:51 PM, Jakob Homan wrote:
> +1
>
> On Thu, Sep 13, 2012 at 5:38 PM, Joel Koshy wrote:
>
> > In KAFKA-391 I tried switching from (topic, partition) tuples to a
> > TopicPartition case class in the producer/fetch request handling code. I
> > think it helped quite a b
+1
On Thu, Sep 13, 2012 at 5:38 PM, Joel Koshy wrote:
> In KAFKA-391 I tried switching from (topic, partition) tuples to a
> TopicPartition case class in the producer/fetch request handling code. I
> think it helped quite a bit in terms of code clarity and access from
> java-api's. There are sti
In KAFKA-391 I tried switching from (topic, partition) tuples to a
TopicPartition case class in the producer/fetch request handling code. I
think it helped quite a bit in terms of code clarity and access from
java-api's. There are still lots of places where we have this:
https://gist.github.com/37