Re: [PATCH 5 of 6 v2] auth: return early in LoginRequired on API key validation

2015-05-13 Thread Thomas De Schampheleire
On May 13, 2015 1:16:17 AM CEST, Mads Kiilerich m...@kiilerich.com wrote: On 05/10/2015 08:22 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427743622 -7200 # Mon Mar 30 21:27:02 2015 +0200 # Node ID

[PATCH] tests: restrict pytest test collection to kallithea/tests

2015-05-13 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1431544206 -7200 # Wed May 13 21:10:06 2015 +0200 # Node ID edce9d365e2d6711e1336ee58a1b20520d8283ae # Parent e19127e4040d1817bbec77118ca7377644f76a64 tests: restrict pytest test collection to

Re: [PATCH] tests: restrict pytest test collection to kallithea/tests

2015-05-13 Thread Marc Abramowitz
Yeah, that seems reasonable. On Wed, May 13, 2015 at 12:34 PM, Mads Kiilerich m...@kiilerich.com wrote: On 05/13/2015 09:26 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1431544206 -7200 # Wed May 13

[PATCH] pullrequest/compare: add logical changeset index to clarify the order

2015-05-13 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1431287504 -7200 # Sun May 10 21:51:44 2015 +0200 # Node ID e19127e4040d1817bbec77118ca7377644f76a64 # Parent 6e8effd028bf41a132aee02e52ffc0bf990dadf4 pullrequest/compare: add logical changeset index

Re: [PATCH] tests: restrict pytest test collection to kallithea/tests

2015-05-13 Thread Mads Kiilerich
On 05/13/2015 10:17 PM, Marc Abramowitz wrote: Yeah, that seems reasonable. Thomas' patch and/or my suggestion? ;-) /Mads On Wed, May 13, 2015 at 12:34 PM, Mads Kiilerich m...@kiilerich.com mailto:m...@kiilerich.com wrote: On 05/13/2015 09:26 PM, Thomas De Schampheleire wrote:

Example of test failure output with pytest

2015-05-13 Thread Mads Kiilerich
Hi Some pytest feedback: I'm sorry for being lazy and not approaching upstream, but it is so appealing to talk directly to the friendly ambassadors ;-) One use case, with https://bitbucket.org/conservancy/kallithea/commits/9b8ba0f1c87b4fe89481b2c2c8723f6636d147cd , I got (valid) test