Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

2015-06-16 Thread Jan Heylen
What I also wanted to say is that the original change is most probably not the issue, it just triggers an underlying issue... What I observed: our kallithea repo: * the issue is still seen on the tip of the default branch * the issue is not seen on the stable branch (as this commit is not on the s

Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

2015-06-16 Thread Jan Heylen
hg update -r 14d75d4b03cd paster setup-db development.ini paster serve ... 1) http://localhost:5000/test-review/settings/advanced --> set test-review a fork of test (test-review has 1 one extra commit) 2) http://localhost:5000/test-review/changelog --> click open a new pull request --> fill in a

New commits on Our Own Kallithea

2015-06-16 Thread Our Own Kallithea
changeset: reduce log level of stack trace on innocent exceptions When the user performs an unallowed action and a flash is displayed, there is no need to l... patrickdp committed on 2015-06-11 06:18:14branch: defaulttag: tipchangeset: 5fb4e6f8changeset: reduce log level of stack trace on

Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

2015-06-16 Thread Mads Kiilerich
On 06/16/2015 08:31 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen # Date 1434479490 -7200 # Tue Jun 16 20:31:30 2015 +0200 # Node ID 3ff99546a950144258be3078b4483e7cebd5d720 # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 backout "pullrequests: don't add automatic 'status

Re: [PATCH] comments: remove dysfunctional comment bubble on compare and file views (issue #84)

2015-06-16 Thread Mads Kiilerich
On 06/13/2015 08:46 AM, Thomas De Schampheleire wrote: On June 12, 2015 11:45:31 PM CEST, Mads Kiilerich wrote: On 06/11/2015 10:59 AM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1432734170 -7200 # Wed May 27 15:42:50 2015 +0200 # Node ID

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

2015-06-16 Thread Mads Kiilerich
On 06/15/2015 04:23 PM, Thomas De Schampheleire wrote: On Mon, Jun 15, 2015 at 2:10 PM, Mads Kiilerich wrote: On 06/14/2015 09:05 PM, Thomas De Schampheleire wrote: Hi Mads, On Fri, Jun 12, 2015 at 11:41 PM, Mads Kiilerich wrote: Anyway, how about a first patch that refactors and consistent

Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

2015-06-16 Thread Jan Heylen
On Tue, Jun 16, 2015 at 9:21 PM, Thomas De Schampheleire wrote: > On Tue, Jun 16, 2015 at 8:31 PM, Jan Heylen wrote: >> # HG changeset patch >> # User Jan Heylen >> # Date 1434479490 -7200 >> # Tue Jun 16 20:31:30 2015 +0200 >> # Node ID 3ff99546a950144258be3078b4483e7cebd5d720 >> # Parent

[PATCH] pullrequests: detect invalid reviewers and raise HTTPBadRequest

2015-06-16 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire # Date 1434282495 -7200 # Sun Jun 14 13:48:15 2015 +0200 # Node ID ad0534276417535724301a0c84ced272940456c1 # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 pullrequests: detect invalid reviewers and raise HTTPBadRequest Normally, the cre

Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

2015-06-16 Thread Thomas De Schampheleire
On Tue, Jun 16, 2015 at 8:31 PM, Jan Heylen wrote: > # HG changeset patch > # User Jan Heylen > # Date 1434479490 -7200 > # Tue Jun 16 20:31:30 2015 +0200 > # Node ID 3ff99546a950144258be3078b4483e7cebd5d720 > # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 > backout "pullrequests: don't

Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

2015-06-16 Thread Jan Heylen
On Tue, Jun 16, 2015 at 8:39 PM, Mads Kiilerich wrote: > On 06/16/2015 08:31 PM, Jan Heylen wrote: >> >> # HG changeset patch >> # User Jan Heylen >> # Date 1434479490 -7200 >> # Tue Jun 16 20:31:30 2015 +0200 >> # Node ID 3ff99546a950144258be3078b4483e7cebd5d720 >> # Parent 53d68f201e4602d

Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

2015-06-16 Thread Mads Kiilerich
On 06/16/2015 08:31 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen # Date 1434479490 -7200 # Tue Jun 16 20:31:30 2015 +0200 # Node ID 3ff99546a950144258be3078b4483e7cebd5d720 # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 backout "pullrequests: don't add automatic 'status

[PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

2015-06-16 Thread Jan Heylen
# HG changeset patch # User Jan Heylen # Date 1434479490 -7200 # Tue Jun 16 20:31:30 2015 +0200 # Node ID 3ff99546a950144258be3078b4483e7cebd5d720 # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 backout "pullrequests: don't add automatic 'status change' message - it will be added in templ